aboutsummaryrefslogtreecommitdiff
path: root/content/en/docs/Contributions
diff options
context:
space:
mode:
authorDimitri Staessens <dimitri@ouroboros.rocks>2020-01-18 11:02:45 +0100
committerDimitri Staessens <dimitri@ouroboros.rocks>2020-01-18 11:02:45 +0100
commita4c051862893517db3d5dbf3a99163086c241838 (patch)
tree25cdd1d5d8adeca5facebedfecd20f4d14f466b8 /content/en/docs/Contributions
parentec0cf3822af30a17cf46dd1a9b02ac2b5ff6ff91 (diff)
downloadwebsite-a4c051862893517db3d5dbf3a99163086c241838.tar.gz
website-a4c051862893517db3d5dbf3a99163086c241838.zip
content: Update contributions page
Diffstat (limited to 'content/en/docs/Contributions')
-rw-r--r--content/en/docs/Contributions/_index.md146
1 files changed, 142 insertions, 4 deletions
diff --git a/content/en/docs/Contributions/_index.md b/content/en/docs/Contributions/_index.md
index e4c3668..46d3fa7 100644
--- a/content/en/docs/Contributions/_index.md
+++ b/content/en/docs/Contributions/_index.md
@@ -6,8 +6,146 @@ description: >
How to contribute to Ouroboros.
---
-{{% pageinfo %}}
-Please join our [slack](https://join.slack.com/t/odecentralize/shared_invite/enQtODk1NDg4OTc0MTc4LWEzZjkzNDhhMGMxMjU2NWNlZTVjMjVjNzY1ZDY3ZDdmZjg5NjVlMjg0NjRkYTMzNDMwMzVkNzMzZjI1Y2ZlMjQ) workspace.
+1. Communication
-Under construction.
-{{% /pageinfo %}}
+There are 2 ways that will be used to communicate: The mailing list
+(ouroboros@freelists.org) will be used for almost everything except
+for day-to-day chat. For that we use the
+[slack](https://odecentralize.slack.com) (invite link in footer) and
+the #ouroboros channel on Freenode (IRC chat). The slack channel is a
+bit more active, and preferred. Use whatever login name you desire.
+
+Introduce yourself, use common sense and be polite!
+
+2. Coding guidelines
+
+The coding guidelines of the main Ouroboros stack are similar as those
+of the Linux kernel
+(https://www.kernel.org/doc/Documentation/CodingStyle) with the
+following exceptions:
+
+- Soft tabs are to be used instead of hard tabs
+
+- A space is to be inserted between a pointer and its object name upon
+ declaration or in function signatures. Example:
+
+```C
+int * a;
+```
+instead of
+
+```C
+int *a;
+```
+
+- Don't explicitly cast malloc, but do
+
+```C
+ptr = malloc(sizeof(*ptr) * len);
+```
+
+- When checking for invalid pointers use
+
+```
+if (ptr == NULL)
+```
+instead of
+```C
+if (!ptr)
+```
+
+When in doubt, just browse the code a bit. It's not rocket science.
+
+3. Development workflow
+
+Git is used as a version tooling for the code. Releases are identified
+through a git tag by a number MAJOR.MICRO.PATCHLEVEL. Incrementing
+MAJOR is done to indicate a big step ahead in terms of features; it is
+discussed when new features are planned. Incrementing MICRO is done
+when APIs/ABIs are not necessarily compatible. The PATCHLEVEL is
+incremented when an urgent bugfix is incorporated.
+
+3.1. Repository structure
+
+The main git repository can be found at:
+https://ouroboros.rocks/cgit/ouroboros
+
+It contains the following branches:
+
+- master: Contains the most stable versions of Ouroboros.
+
+- testing: Contains tested code but may still contain bugs.
+
+- be: Contains untested but compiling code.
+
+All new contributions are integrated into 'be' through patches sent to
+the mailing list. Once a version of 'be' is tested enough, it is
+merged into 'testing'. When a 'testing' version is considered stable
+enough, it is merged into 'master'. Users should ALWAYS use master
+unless told otherwise.
+
+3.2. Contributions
+
+There is 1 way to provide contributions:
+
+- git email patch: via mailing list (ouroboros@freelists.org)
+
+New development is ALWAYS done against the 'be' branch of the main git
+repository. Contributions are always made using your real name and
+real e-mail address.
+
+3.3 Commit messages
+
+A commit message should follow these 9 simple rules (adjusted from
+http://chris.beams.io/posts/git-commit/):
+
+- Separate subject from body with a blank line
+
+- Limit the subject line to 50 characters
+
+- Capitalize the subject line
+
+- Do not end the subject line with a period
+
+- Use the imperative mood in the subject line
+
+- Precede the subject line by indicating the component where changes
+were made
+
+- Wrap the body at 72 characters
+
+- Use the body to explain what and why vs. how
+
+- If the commit addresses a bug, reference it in the body
+
+- Sign off your commits using the signoff feature in git
+
+3.4 Bugs
+
+Bugs are reported through the Bugzilla issue tracker
+(https://ouroboros.rocks/bugzilla/). The process of reporting
+a bug is the following:
+
+- Provide a description of the bug
+
+- Provide system logs
+
+- Provide a minimal code example to reproduce the bug if possible
+
+- Check if the bug is still present in the be branch
+
+- Sync with the HEAD of the most stable branch where the bug is present
+
+- Provide a bug fix if you can, send a patch to the mailing list
+
+Note that the first 2 steps are always required by the bug
+reporter.
+
+4. New features
+
+New features can be always be requested through the mailing list. They
+will be taken into account when a next version of the prototype is
+discussed. Patches containing non discussed features are likely to be
+rejected.
+
+We're a small community. Rome wasn't built in a day.