lib, ipcpd, irmd: Wrap pthread unlocks for cleanup

This add an ouroboros/pthread.h header that wraps the
pthread_..._unlock() functions for cleanup using
pthread_cleanup_push() as this casting is not safe (and there were
definitely bad casts in the code). The close() function is now also
wrapped for cleanup in ouroboros/sockets.h.
This allows enabling more compiler checks.

Signed-off-by: Dimitri Staessens <dimitri@ouroboros.rocks>
Signed-off-by: Sander Vrijders <sander@ouroboros.rocks>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/lib/notifier.c b/src/lib/notifier.c
index 06f15681..1f600765 100644
--- a/src/lib/notifier.c
+++ b/src/lib/notifier.c
@@ -25,8 +25,9 @@
 #include <ouroboros/errno.h>
 #include <ouroboros/notifier.h>
 #include <ouroboros/list.h>
+#include <ouroboros/utils.h>
+#include <ouroboros/pthread.h>
 
-#include <pthread.h>
 #include <stdlib.h>
 
 struct listener {
@@ -75,8 +76,7 @@ void notifier_event(int          event,
 
         pthread_rwlock_rdlock(&notifier.lock);
 
-        pthread_cleanup_push((void (*) (void *)) pthread_rwlock_unlock,
-                             (void *) &notifier.lock)
+        pthread_cleanup_push(__cleanup_rwlock_unlock, &notifier.lock)
 
         list_for_each(p, &notifier.listeners) {
                 struct listener * l = list_entry(p, struct listener, next);