| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
|
| |
dev.c: read now only reads an SDU if is is for the correct port_id
shm_ap_rbuff: added a function peek() that returns the port_id of the
tail.
|
| |
|
|
|
| |
There could be a theoretical race condition that the server sends a
message before the FD is set on the client side, which is resolved.
|
| |
|
|
|
|
|
|
|
|
|
| |
There were two race conditions. The first was where client received
the response message before the client UDP port was connected to the
server UDP port and the first message of the client was sent to the
LISTEN port instead of the server application port. This was solved by
reordering the operations so the response is sent after the port is
correctly connected. The second race condition is that the FD is not
added to the set in time at the server side before the first SDU
arrives. This was solved by adding a variable proteceted by a mutex.
|
| |
|
|
|
| |
some debug code for locking and a sleep check are removed from the
shim-udp.
|
| |
|
|
|
|
|
|
|
| |
It uses UDP port 0x0D1F on all hosts to send and receive flow
allocation messages. It supports communication between server and
client AP over a single shim IPCP.
Implementation of full flow deallocation is pending. Both the client
and the server still have to call flow_dealloc();
|
| |
|
|
|
|
|
| |
There was a check missing upon garbage collection. If the whole DU map
has been used once, all DUs will have their garbage bit set to
one. This meant that the garbage collector would keep moving the tail
indefinitely.
|
| |
|
|
|
| |
When moving the tail pointer in the DU map, blocks was never reset to
zero. This caused it to sometimes clean up too many DUs.
|
| | |
|
| |
|
|
|
|
| |
Adds a missing modulo calculation that would result in index -1 being
returned instead of zero when the ringbuffer skipped back to the
beginning.
|
| |\
| |
| |
| | |
lib: dev: small locking improvements
|
| | |
| |
| |
| |
| |
| | |
This avoids holding the long locks during accept() and alloc_res()
calls. Small reduction of time of other locks held. No changes in
locking logic.
|
| | |\ |
|
| |\ \ \
| | | |
| | | |
| | | | |
irmd: new locking implementation
|
| | | | |
| | | |
| | | |
| | | | |
unlock is now called before the object is destroyed.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This locking should be more consistent, It now has three locks, one
guarding flows and port_id's, one guarding the registered apps and
ipcps, and one guarding the overall state of the irmd. There are two
additional mutexes guarding the condition variables.
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | | |
ipcpd: shim-udp: Revised locking
|
| | | |/
| |/| |
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Simplified locking to take only two locks: the first lock guards the
state of the ipcp. This lock must be held for writing on bootstrap and
closing, and held for reading during all other operations. The second
lock guards operations on flows, and must be held for writing during
allocation and deallocation, and held for reading when sending sdu's.
After adding a fd to FD_SET, the shim will wait for 1 ms to ensure
that the FD is added to the select call.
|
| |/
|
|
|
| |
fd and flows are now all protected by the flows_lock while the overall
state of the AP is protected by the data_lock.
|
| |
|
|
| |
The application can call accept(fd, NULL, NULL);
|
| |
|
|
|
| |
cleanup of file descriptors for the shared memory.
also adds a missing NULL check and some invalidation in dev.c
|
| |
|
|
|
| |
This takes a lock before notifying the IRMd of a new flow request, to
avoid race conditions when trying to retrieve the fd by port-id.
|
| | |
|
| |
|
|
| |
Used simpler pointer arithmetic to calculate the file offset pointers.
|
| |
|
|
|
| |
Port_id's weren't correctly released. Also removes remaining debug
logs from the library.
|
| |
|
|
|
| |
The fd_to_port_id function has no internal locking and must now be
called under lock.
|
| |\
| |
| |
| | |
lib, ipcpd, irmd: Add QoS cube definition
|
| | |
| |
| |
| |
| |
| | |
This fixes wrong header inclusion that would make programs which are
not developed within ouroboros fail upon compilation, since they would
not find certain headers on their system.
|
| | |\ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This adds the QoS cube definition, which is an enum to select which
QoS is needed in the IPCP. An application has to use the qos_spec in
qos.h to define what it needs. The IRMd will map this unto a qos cube
definition.
Some headers are now also no longer installed on the system, since
they are only to be used within the irmd and ipcps.
|
| |\ \ \
| | | |
| | | |
| | | | |
lib: dev.c: added locking
|
| | | |/
| |/|
| | |
| | |
| | | |
Locking is required for multi-threaded applications. Flows are locked
separately. Read/Write locks are used for concurrent reads.
|
| | |\| |
|
| | | |
| | |
| | |
| | |
| | | |
moved a malloc so there is no malloc/free when there is no data to be
read from the shm_ap_rbuff.
|
| | | | |
|
| |/ /
| |
| |
| |
| |
| |
| | |
Added necessary locks for the shim-udp. This PR also improves thread
management, the main thread now starts a mainloop thread, which spawns
sdu handler threads when it the IPCP is enrolled. If the IPCP exits
the enrolled state, the sdu loop is cancelled.
|
| | |
| |
| |
| | |
Locking the main mutex should happen while the counter is locked.
|
| |/
|
|
|
| |
This adds read/write locks, allowing for concurrent reads on the locked
datastructure. This is needed for the fast path.
|
| |
|
|
| |
Unnecessary filename string removed. Formatting fix.
|
| |
|
|
| |
flow_alloc_res had missing cleanup, added missing unlock.
|
| | |
|
| |
|
|
|
| |
allows setting the oflags to make flow_read and flow_write blocking or
non-blocking (FLOW_O_NONBLOCK).
|
| |
|
|
| |
improved cleanup when killing the IRMd.
|
| |
|
|
|
| |
The shim_udp now correctly destroys its ringbuffer on exit. Now
handles sdu's in a single thread using select() with a 10 us timeout.
|
| |
|
|
|
| |
A value that was unitialized was being treated as an error in the
release build with gcc.
|
| |
|
|
|
| |
This adds nslookup support to the shim UDP, so that a custom DNS
server can be queried.
|
| |
|
|
|
|
| |
This allows someone to disable the use of DNS in the shim UDP. It also
adds a config file specific for the shim UDP (which holds the nsupdate
location). Certain defines were also moved to the global config file.
|
| |
|
|
|
| |
it's more robust to use dedicated locks for pthread_cond_signal so no
other threads can be waiting for the mutex.
|
| |
|
|
|
| |
bmp_allocate should be called under lock. Helgrind does not give
warnings anymore during flow allocation.
|
| | |
|
