summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* lib, ipcpd, irmd: Fix several memleaksSander Vrijders2017-08-236-9/+10
| | | | | This fixes several memleaks as reported by valgrind. It also fixes some calls to close() with -1.
* lib: Make sender and receiver inactivity simple checksSander Vrijders2017-08-231-153/+68
| | | | | | This makes the sender and receiver inactivity timers into simple checks that compare when the last SDU was sent to the current time to set the receiver or sender inactivity.
* Merge branch 'testing' into beSander Vrijders2017-08-231-3/+5
|\
| * irmd: Fix potential data race in irmdSander Vrijders2017-08-231-3/+5
| | | | | | | | | | If the IPCP was not created, the printing of the log may use a variable that was already freed.
* | ipcpd: shim-eth-llc: Fix building LLC shimSander Vrijders2017-08-232-3/+6
| | | | | | | | | | | | | | The LLC shim was not being built even though it should be build. This is due to CMake behaviour that when you set a var in the parent scope, it is not set in the local scope. It also adds back THIS_TYPE to the shim-eth-llc.
* | lib: Remove bad assertionSander Vrijders2017-08-231-1/+0
| | | | | | | | | | Timeout was asserted not to be NULL, but sometimes timeout can be NULL and is a valid parameter when NULL.
* | ipcpd: Fix data race in connmgrdimitri staessens2017-08-221-0/+5
| | | | | | | | The removal of the mutex and signal in 198b709 was a mistake.
* | lib: Fix timeout value of flow_event_waitSander Vrijders2017-08-222-5/+7
| | | | | | | | | | shm_flow_set_wait was called with a timeout even though flow_event_wait was called with timeout NULL.
* | lib: Fix calling frct_clear in wrong functionSander Vrijders2017-08-221-2/+2
| | | | | | | | frct_clear was called in ouroboros_fini instead of ouroboros_init.
* | lib: Fix CRC check and add frct_clearSander Vrijders2017-08-223-16/+41
| | | | | | | | | | | | This adds the CRC check by default on outgoing SDUs. It fixes some errors in the serialization and deserialization of the SDU. frct_clear was added to avoid bad initialization of the array of FRCT instances.
* | Merged in sandervrijders/ouroboros/be-tw (pull request #560)Sander Vrijders2017-08-224-164/+25
|\ \ | | | | | | | | | Be tw
| * | lib: Make timerwheel a passive componentSander Vrijders2017-08-223-162/+23
| | | | | | | | | | | | | | | | | | This turns the timerwheel into a passive component since it is used by application using the library. The user of the timerwheel now has to call timerwheel_move to advance the timerwheel.
| * | lib: Fix check for robust mutexesSander Vrijders2017-08-221-2/+2
| | | | | | | | | | | | | | | There was an else clause matched with the wrong if statement, resulting in robust mutexes being enabled even in glibc 2.25.
* | | lib, irmd: Use static buffer for messagesdimitri staessens2017-08-222-36/+20
| | |
* | | ipcpd: Improve locking in connmgrdimitri staessens2017-08-223-66/+93
|/ /
* | Merged in dstaesse/ouroboros/be-build (pull request #557)dimitri staessens2017-08-2181-484/+613
|\ \ | | | | | | | | | build: Revise the build system
| * | build: Revise the build systemdimitri staessens2017-08-2181-484/+613
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This revises the build system to have configuration per system component. System settings can now be set using cmake. The standard compliance defines were removed from configuration header and are set in the sources where needed. Also some small code refactors, such as moving the data for shims out of the ipcp structure to the respective shims were performed.
* | | Merge branch 'testing' into beSander Vrijders2017-08-202-19/+34
|\ \ \ | |/ / |/| / | |/
| * ipcpd, irmd: Fix data racesdimitri staessens2017-08-192-19/+34
| | | | | | | | | | | | Fixes a data race in the IRMd when IPCPs bail immediately after being created (e.g. due to an error). Fixes a race between the acceptor threads and the threads managed by threadpool manager upon shutdown.
* | lib: Add basic FRCT mechanismsSander Vrijders2017-08-1713-266/+595
|/ | | | | | | | | | This adds the basic FRCT mechanisms to the library. Upon flow alloc or accept an FRCT instance is now created and used when reading or writing to the flow. The timerwheel has been refactored to allow recharging timers and removing them and is now part of the library. The first SDU sent over the connection has the DRF set and this initializes the connection. Sender and receiver inactivity timers are added.
* irmd: Handle IPCP creation fails gracefullydimitri staessens2017-08-172-35/+52
|
* ipcpd: Support Berkeley Packet Filter in LLC shimdimitri staessens2017-08-173-147/+250
| | | | | This adds support reading Ethernet frames using the Berkeley Packet Filter (BPF). Ouroboros now fully runs on OS X Sierra.
* lib: Check system-specific call firstdimitri staessens2017-08-171-6/+6
| | | | The build failed on OS X if an old version of libgrypt is installed.
* irmd, ipcpd: Signal acceptor onlydimitri staessens2017-08-163-5/+24
| | | | | This adds an extra condvar so the mainloops can signal the acceptor thread without waking up all mainloops.
* ipcpd: Fix missing clock_gettime in flow allocatordimitri staessens2017-08-161-0/+2
|
* ipcpd: Refactor normal IPCP failure handlingdimitri staessens2017-08-161-35/+24
|
* irmd, ipcpd: Listen on a dedicated accept() threaddimitri staessens2017-08-163-131/+323
| | | | | | | | | | | The IRMd and IPCPs will now call accept on their command sockets from a single thread that will dispatch work to the other threads. This solves a problem on OS X and FreeBSD where accept() doesn't time out when setting SO_RCVTIMEO on the socket. Calling kqueue or select() on that socket to wait for events before calling accept() didn't solve it since select() or kqueue() might wake up multiple threads, with the non-working threads again blocked on the accept() on shutdown.
* build: Replace fsf snail mail with contact URLdimitri staessens2017-08-13151-190/+151
|
* lib: Fix data race on fqueues bitmapdimitri staessens2017-08-131-126/+143
| | | | | | This locks the process when allocating and destroying flow_sets. The flows_lock has been renamed to lock. Refactors and fixes a memleak in ouroboros_init.
* lib: Fix TPM thread count on failuredimitri staessens2017-08-131-1/+1
|
* Merged in dstaesse/ouroboros/be-tpm (pull request #550)dimitri staessens2017-08-132-38/+85
|\ | | | | | | lib: Fix instability in threadpool manager
| * ipcpd: Fix tracking of outstanding DHT requestsdimitri staessens2017-08-131-7/+28
| | | | | | | | | | | | The DHT failed when receiving multiple responses in a short timeframe. The lookup struct now keeps track of the number of outstanding requests.
| * lib: Fix instability in threadpool managerdimitri staessens2017-08-121-31/+57
| | | | | | | | | | | | The threadpool manager now tracks threads to prevent cyclic behaviour where too many threads shut down and the TPM responds with creating additional threads.
* | irmd: Fix mainloop timeout on OS Xdimitri staessens2017-08-111-2/+2
| |
* | build: Fix compilation on OS X Sierradimitri staessens2017-08-1110-35/+47
|/
* lib, ipcpd, tools: Fix enum assignmentsSander Vrijders2017-08-103-12/+6
| | | | This fixes several assignments to the wrong enum type.
* build: Reset LIBGCRYPT_LIBRARIES when not founddimitri staessens2017-08-101-0/+2
|
* build, lib, ipcpd, irmd: Add support for libgcryptdimitri staessens2017-08-0910-76/+142
| | | | | | | | | | | | | | | | This adds support for libgcrypt. If at least version 1.7.0 of libgcrypt is present, it may be used for secure random number generation and is used for hashing in the irmd/ipcp. The hash definitions are moved to the internal hash.h header, and defined independently of the hashes that are defined as part of the directory policy for the normal IPCP. The translation is moved from the IRMd to ipcpd/ipcp.h. The bootstrap call from the IRMd expects the IPCP to return the correct hash algorithm with a dif_info struct, which is in line with the behavior of the enroll call. This also improves how some platform checks in the build system are handled.
* ipcpd: Fix assignment of fd's in flow allocatorDimitri Staessens2017-08-081-2/+4
|
* ipcpd: Fix finding values in DHTDimitri Staessens2017-08-051-5/+18
| | | | | | | | | The DHT lookup would stop if a node returned no new useful information (i.e. the value for the key or unknown nodes closer to the key) without waiting for other pending requests that could still return useful information. Now it correctly tracks the number of outstanding requests or returns if it doesn't get a response for KAD_T_RESP seconds. This fixes multi-hop flow allocation over the normal.
* irmd: Don't self-query an IPCPDimitri Staessens2017-08-051-4/+5
| | | | | | Upon flow_allocation, the IRMd queries IPCPs for the destination name. After this commit, when an IPCP allocates a flow, the IRMd won't query that IPCP.
* irmd: Don't call ipcp_flow_dealloc under lockDimitri Staessens2017-08-051-3/+13
| | | | | | | | | | When a process was killed, ipcp_flow_dealloc was called under a lock, causing a deadlock in the IRMd because handling the IPCP response also needs to take the same lock (the IPCP calls flow_dealloc to finalize this). This deadlock also resulted in the IPCP always reporting that it failed to send a reply message as the deadlock effectively blocks the IRMd until its socket timeout expired and thus the IPCP was always responding to an already closed socket.
* irmd: Specify timeout per commandDimitri Staessens2017-08-051-22/+44
| | | | | | | The commands towards the IPCPs have different time requirements, but the irmd had only a single timeout value to wait for a response. This commit allows setting different timeouts for the IRMd based on the command, configurable globally.
* Merge branch 'testing' into beSander Vrijders2017-08-042-9/+17
|\
| * ipcpd: Fix missing space in shim-eth-llcdimitri staessens2017-08-041-1/+1
| |
| * irmd: Release lock before ipcp_querydimitri staessens2017-08-041-8/+16
| | | | | | | | | | | | The blocking ipcp_query call was called under reg_lock, causing flow_allocs over the shim-eth-llc to block the irmd for prolonged timespans.
* | Merge branch 'testing' into beSander Vrijders2017-08-034-16/+54
|\|
| * ipcpd: Fix pthread_cond_timedwait deadlinesdimitri staessens2017-08-034-16/+54
| | | | | | | | | | | | This fixes pthread_condtimedwaits in the flow allocator of all IPCPs that had bad deadlines set (the interval instead of the actual absolute time).
* | build: Add check for robust mutexesSander Vrijders2017-08-037-30/+29
| | | | | | | | | | | | This adds a check for robust mutexes. The constant HAVE_ROBUST_MUTEX is set accordingly in config.h. It also adds some other fixes to make the prototype compile on the Hurd.
* | lib: Simplify initializing flowsSander Vrijders2017-08-014-326/+84
| | | | | | | | | | This refactors dev.c to have a common function called init_flow that is called whenever a flow is allocated in dev.c