summaryrefslogtreecommitdiff
path: root/src/ipcpd
Commit message (Collapse)AuthorAgeFilesLines
* ipcpd: local: Handle failed flow allocationSander Vrijders2017-03-211-1/+7
| | | | | | When the flow_req_arr returned a negative error, it was not handled correctly in the local IPCP, and an access was made into a table with a negative integer. This handles it correctly.
* irmd: Fix timeouts in reg_entrydimitri staessens2017-03-211-6/+4
| | | | | This fixes bad timedwaits for the state of the reg_entry. Also slightly revised timedwaits throughout the prototype.
* irmd: Check IPCP type before bootstrapdimitri staessens2017-02-221-4/+2
| | | | | This prevents assertion failures in the IPCP in some cases. IPCPs can now safely assert the type.
* ipcpd: Move RIB configuration to common headerdimitri staessens2017-02-1710-26/+57
| | | | | Moves the definitions of paths in the RIB for the normal IPCP to a header ribconfig.h to avoid repetition.
* lib: Revise endian header and SHA3Sander Vrijders2017-02-161-1/+1
| | | | | | | | This revises the endian header to let the build time checks of endianness be performed by the standard libraries. We just check for the OS that is being used and provide the endian functions from OpenBSD to everyone. It also updates the SHA3 sources to use this new header. The byte order header is removed.
* ipcpd: Add lock to tx_ring datadimitri staessens2017-02-131-1/+49
| | | | Also fixes another lock.
* ipcpd: Fix build on FreeBSDdimitri staessens2017-02-131-1/+1
| | | | | Use labs for absolute value of a long, and defines bswap_64 as the FreeBSD function bswap64.
* ipcpd: Increase threadpool sizeSander Vrijders2017-02-132-2/+1
| | | | | | This increases the threadpool size for the IPCP main loop. Starvation was happening due to a lot of back and forth interactions between the normal IPCPd and the IRMd.
* ipcpd: Fix timeout in ipcp_wait_statedimitri staessens2017-02-121-2/+2
|
* include: Use width in endian naming conventiondimitri staessens2017-02-121-4/+4
| | | | | ntohll and ntohl have been renamed ntoh64 and ntoh32, htonll and htonl have been renamed hton64 and hton32.
* ipcpd: Prevent access to directory before initdimitri staessens2017-02-111-4/+14
| | | | | | | Doing a directory query before the IPCP is has bootstrapped or is enrolled will result in an assertion failure as the directory is not yet ready. This fixes flow allocation over the LLC shim (which triggers a directory query from the IRMd) with a normal IPCP present.
* ipcpd: Compare timestamp upon enrollmentdimitri staessens2017-02-111-1/+52
| | | | | | The enrollment procedure will ask for a timestamp of the IPCP it is enrolling with. It will (taking into account the RTT of the request) issue a warning if the offset is larger than RIB_WARN_TIME_OFFSET ms.
* ipcpd: Silent shutdown of normaldimitri staessens2017-02-101-2/+3
| | | | | The acceptor will not log disconnects with IRMd. Unexpected disconnects will be reported and handled by management components.
* Merged in sandervrijders/ouroboros/be-ipcpd-logs (pull request #370)Sander Vrijders2017-02-105-7/+1
|\ | | | | | | ipcpd: Remove logging if not initialized yet
| * ipcpd: Remove logging if not initialized yetSander Vrijders2017-02-105-7/+1
| | | | | | | | | | | | This removes the logs that would print to stdout if the IPCP fails to initialize. If the user had asked that logs would be printed to the syslog this would be unwanted behaviour.
* | ipcpd: Fix leaking name in cacep_infodimitri staessens2017-02-102-0/+3
|/
* lib, ipcp: Correctly init condvarsdimitri staessens2017-02-092-11/+14
| | | | | The timerwheel and RIB use timedwaits. The condition variables are now correctly initialised to use the configuration defined clock.
* ipcpd: Print size_t and uint64_t in portable waydimitri staessens2017-02-092-6/+7
| | | | | | On 32-bit systems size_t is different than on 64 bit systems. The correct way to print a size_t is with %z. uint64_t is printed portably with the PRIu64 macro.
* lib, tools, ipcpd: Fix compilation on FreeBSDdimitri staessens2017-02-091-1/+0
| | | | | | | | | | | | FreeBSD defines its own bswap64 in the <sys/endian.h> header, which is now included correctly. POSIX requires XSI or RTS extensions to be enabled for the sa_sigaction field to be visible. Linux doesn't do the check correctly, but FreeBSD does. Removes the LOG_MISSING call which was deprecated with the last revision of the logging system.
* ipcpd, lib: Report IPCP creation failuredimitri staessens2017-02-095-13/+18
| | | | | | | | The IPCP will now respond with an ipcp_create_r message when it fails, informing the IRMd. Also adds some const qualifiers in the public headers and fixes some formatting in dev.c.
* ipcpd: Add cleanup handler to gamdimitri staessens2017-02-081-1/+4
|
* ipcpd: Fix boot order of normaldimitri staessens2017-02-081-4/+10
| | | | | | irm_bind has to be called after ipcp_init() since it targets the AP-I and needs the pid to be registered with the IRMd. Also fixes missing unbinding of the AP-I.
* lib: Log to the logging systemdimitri staessens2017-02-0815-436/+402
| | | | | | | | | | This removes the logfile and outputs log messages to the logging system. The creation of the logfiles (as well as the ap_init() call) were moved into ipcp_init() to simplify the IPCP creation and shutdown. Fixes #25 Fixes #27
* ipcpd: Refactor ipcpi structdimitri staessens2017-02-079-141/+161
| | | | | | | | | The ipcp-ops header was removed and merged into ipcp.h. The common components dif_name and ipcp_type have been moved to the main ipcp struct. After this move, ipcp_data only contained shim information, so it was renamed to shim_data. The ipcp_init() function checks the type and will only include the shim_data if the type is not an IPCP_NORMAL. All ipcps have been adapted to this change in API.
* ipcpd: Revise PCI manipulation in normaldimitri staessens2017-02-073-134/+92
| | | | | | | | | | | The pci function will store offsets to avoid having to recalculate them every time. TTL handling is removed from the fmgr, the TTL is automatically decreased when deserializing the PCI (or set to 1 if there is no TTL present so the PDU will be forwarded). The deserialisation function now takes a pointer to a struct pci as input to avoid memory allocation and release each time a PDU is processed. Some checks have been replaced with assert() and return values replaced with void where it makes sense.
* ipcpd, lib: Revise normal IPCPdimitri staessens2017-02-0626-2536/+1013
| | | | | | | | | | This PR updates the normal IPCP to use the new RIB. The old ribmgr is removed and replaced by a stub that needs to be implemented. All components (dir, fmgr, frct) were adapted to the new RIB API. A lot of functionality was moved outside of the ribmgr, such as the addr_auth, which is now a component of the IPCP. The address is also stored to the ipcpi struct. The irm tool has an option to set the gam policy of the rib manager.
* ipcpd: Remove strdup() from ipcp main loopdimitri staessens2017-02-035-11/+26
|
* ipcpd: Fix unused parameter in local IPCPdimitri staessens2017-01-291-0/+2
|
* ipcpd: Don't strdup() the dif_name in main loopdimitri staessens2017-01-295-14/+8
|
* lib: Move CRC32 implementation to librarydimitri staessens2017-01-144-113/+1
| | | | The CRC32 implementation will be used to ID objects in the RIB.
* ipcpd: Fix timerwheel testdimitri staessens2017-01-131-1/+5
| | | | | | | | Sometimes the timerwheel test could fail because of scheduler timings (an issue more apparent in Virtual Machines). When the first check fails, the test will wait for another complete round of the timerwheel. The maximum number of slots in the test is reduced to reduce the test time.
* ipcpd: normal: Create policies for GAMSander Vrijders2017-01-1211-111/+367
| | | | | This allows the selection of a policy for the graph adjacency manager. Currently we only support constructing a complete graph.
* ipcpd: normal: Use new list APISander Vrijders2017-01-112-6/+6
| | | | | After a previous commit the API of the linked list was changed. This updates the files that were not yet merged upstream.
* Merge remote-tracking branch 'upstream/be' into be-gamSander Vrijders2017-01-0929-41/+41
|\
| * build: Update licenses and copyrightdimitri staessens2017-01-0930-30/+30
| | | | | | | | | | Copyright is set to 2016 - 2017. License text on includes and sources in the library are changed to indicate the LGPLv2.1 license.
| * lib: Revise implementation of listdimitri staessens2017-01-093-13/+13
| | | | | | | | Adds LGPL license to the ouroboros lists.
* | ipcpd: normal: Add graph adjacency managerSander Vrijders2017-01-097-85/+523
| | | | | | | | | | This commit adds the graph adjacency manager to the normal IPCP, which sets up N-1 flows to other members.
* | ipcpd: Let IPCPs bind a nameSander Vrijders2017-01-096-38/+25
|/ | | | | | | This allows IPCPs to bind a name, so that they can announce their name to neighbors which can then allocate a flow to them. Registering of the name happens by an administrator. It also moves the irmd_api to common ground, since it is used by all IPCPs.
* ipcpd: Fix state in ipcp_bootdimitri staessens2017-01-041-2/+3
| | | | | | The state must be set to IPCP_INIT before the main_loop threads are started or else they will exit if they reach the check earlier than the state is set.
* ipcpd: Fix memleaks in directorydimitri staessens2017-01-041-0/+9
|
* ipcpd: Revert normal IPCP state correctlydimitri staessens2017-01-041-0/+2
| | | | | The state of the IPCP should revert to INIT when pthread_create fails in the normal and bootstrapping procedures.
* ipcpd: Add boot and shutdown operationsdimitri staessens2017-01-046-78/+152
| | | | | | | These operations separe the starting and joining of the main ipcp threads into ipcp_boot() and ipcp_shutdown() operations. This allows the proper cleanup of user data and user threads after the IPCP is requested to shut down.
* ipcpd: normal: Fix bad unlockSander Vrijders2017-01-041-2/+0
| | | | This removes a bad unlock in the flow manager.
* Merged in dstaesse/ouroboros/be-normal-refactor (pull request #334)Sander Vrijders2017-01-041-3/+4
|\ | | | | | | ipcpd: Initialize rnodes in ribmgr_ro_create
| * ipcpd: Initialize rnodes in ribmgr_ro_createdimitri staessens2017-01-041-3/+4
| | | | | | | | Fixes warnings by some compilers about possibly uninitialized access.
* | Merged in dstaesse/ouroboros/be-normal-refactor (pull request #333)Sander Vrijders2017-01-042-5/+9
|\| | | | | | | ipcpd: Fix uninitialized variables in ribmgr
| * ipcpd: Fix bug in fmgrdimitri staessens2017-01-041-2/+2
| |
| * ipcpd: Fix uninitialized variables in ribmgrdimitri staessens2017-01-041-3/+7
| |
* | Merged in dstaesse/ouroboros/be-normal-refactor (pull request #331)Sander Vrijders2017-01-0412-342/+463
|\| | | | | | | ipcpd: Refactor normal ipcp, initial commit
| * ipcpd: Refactor of normal IPCPdimitri staessens2017-01-0412-342/+463
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Reorganizes the normal IPCP a bit to make sure internal components do not need to access the state of the IPCP. The IPCP has now a thread calling accept and delegating it to the correct component based on the AE name (this used to be in the fmgr). Internal components are initialized upon enrollment or bootstrap of the IPCP. If a step fails, the IPCP goes back to the INIT state, if all components boot correctly, it goes to the operational state. RIB synchronization is still done by sending a CDAP start/stop and syncing with a ribmgr state, but needs revision later on.