summaryrefslogtreecommitdiff
path: root/src/ipcpd/shim-eth-llc
Commit message (Collapse)AuthorAgeFilesLines
...
* ipcpd: Fix log message and lockdimitri staessens2016-10-231-3/+2
| | | | | Remote requests for a flow that's locally deallocated should not generate an error. Sending messages should not be under lock.
* dev, ipcp: Fix setting default flow optionsdimitri staessens2016-10-231-9/+2
| | | | | The default flow options were not set when a flow allocation request arrives remotely. This went unnoticed due to a previous bug.
* build: Compile with strict conversiondimitri staessens2016-10-222-17/+23
| | | | | This has the code checked with -Wcast-qual and -Wconversion flags. These flags were removed because SWIG generated code fails.
* build: Comply with -Wextra compiler flagdimitri staessens2016-10-211-4/+10
| | | | | This reduces the risk for some bugs, for instance due to signed/unsigned mismatches and unused variables.
* lib: Demultiplex the fast pathdimitri staessens2016-10-211-35/+71
| | | | | | | | The fast path will now use an incoming ring buffer per flow per process. This necessitated the development of a new method for the asynchronous io call, which is now based on an event queue system for scalability (fqueue). The ipcpd's and tools have been updated to this API.
* lib: Fix flow deallocation logicdimitri staessens2016-10-131-0/+2
| | | | | Both the N and N-1 entity must now call flow_dealloc for the port_id to be released.
* lib: Add non-copy reading from fd for IPCPsdimitri staessens2016-10-071-1/+1
|
* ipcpd: Filter traffic on shim-eth-llcdimitri staessens2016-10-061-6/+28
| | | | Now correctly handles and drops non-ouroboros traffic.
* ipcpd: shim-eth-llc: Use correct SAP to lookup in the tableSander Vrijders2016-10-051-3/+5
| | | | | Upon deallocation, the remote's SAP was being used to lookup the fd instead of our own SAP. This resulted in strange behaviour.
* lib, ipcpd: Fix bad lockingSander Vrijders2016-10-051-5/+2
| | | | | | Some locks were taken at an inappropriate time, causing the shim-eth-llc to block indefinitely upon shutdown and causing flow allocation to halt since a response could never be given.
* lib, ipcp: Revise fast path and flow interfacesdimitri staessens2016-10-041-645/+333
| | | | | | | | | | | | IPCPs can now use ap_init() to initialize the memory. All flows are accessed using flow descriptors, this greatly simplifies IPCP development. Reverts the fast path to a single ap_rbuff per process. Splits lib/ipcp into irmd/ipcp and lib/ipcp-dev. Adds a lib/shim-dev holding tailored functions for shims. Moves the buffer_t to utils.h. Fixes the shim-eth-llc length field. Removes the flow from shared.h. Fixes #4 Fixes #5
* ipcpd: Add missing include for FreeBSDdimitri staessens2016-09-071-0/+1
|
* Merged in dstaesse/ouroboros/be-split-fp (pull request #238)Sander Vrijders2016-09-021-3/+3
|\ | | | | | | lib: Add northbound ringbuffers
| * lib: Add northbound ringbuffersdimitri staessens2016-09-021-3/+3
| | | | | | | | Fast path is split in north and southbound paths.
* | lib: ipcp: Decouple flow_deallocdimitri staessens2016-09-021-1/+1
|/ | | | Sending a dealloc to the irmd moved to its own call.
* lib: Refactor shm_du_map to shm_rdrbuffdimitri staessens2016-08-291-30/+33
| | | | | | | | | | The shm_du_map is renamed to shm_rdrbuff to reflect the Random Deletion Ringbuffer used in the implementation. The close_on_exit call is removed and SDUs are cleaned up by the application in the ap_fini() call. This required a non-blocking peek() operation in the shm_ap_rbuff. Some initial implementation for future support of qos cubes has been added to the shm_rdrbuff.
* ipcpd: Report pid on shutdowndimitri staessens2016-08-261-2/+2
| | | | IPCPs will report their pid on shutdown for faster debugging.
* ipcpd: Revised lockingdimitri staessens2016-08-241-88/+55
| | | | | | The state lock was reverted to an rwlock to avoid interference of management functions with the fast path. IPCPs now close without calling unsafe functions in the signal handler.
* ipcpd: Add condition variable to IPCP stateSander Vrijders2016-08-111-50/+50
| | | | | | | This adds a condition variable to the IPCP state, so that upon state changes any listeners to state changes can be notified. It also replaces the read/write lock with a mutex in order to be able to do so.
* ipcpd: Put correct max SDU length in shim-eth-llcSander Vrijders2016-08-111-22/+7
| | | | | Now the correct max length of an SDU is checked upon writing a frame, as well as on receiving it.
* ipcpd: Add MSG_DONTWAIT flag to shim-eth-llcSander Vrijders2016-08-101-1/+1
| | | | | | This adds the MSG_DONTWAIT flag to the send function of the shim-eth-llc, when using PF_PACKET. Previously the send would return only after the frame was sent, resulting in poor performance.
* ipcp, irmd, lib: Notify IRMd upon IPCP initializationSander Vrijders2016-08-101-0/+6
| | | | | | This will notify the IRMd when the IPCP is initialized and ready to receive messages. Previously a bootstrap could fail since the IPCP was not listening to the socket yet.
* ipcpd: Fix locking of shim-eth-llcSander Vrijders2016-08-091-9/+2
| | | | | | This changes the amount of time the shim-eth-llc will hold the IPCP state lock when sending and receiving frames. Before it was holding the lock for too long.
* ipcpd: normal: Allow exchange of static DIF informationSander Vrijders2016-08-081-0/+1
| | | | | | This adds the functionality of exchanging the static DIF information between 2 DIF members. After exchange the enrollment is stopped, and the IPCP that initiated enrollment transitions to the enrolled state.
* ipcpd: Fix memleakdimitri staessens2016-08-051-0/+2
| | | | The entry from the ringbuffer was never freed, causing memleak per SDU.
* ipcpd: Fix memory leaksdimitri staessens2016-08-041-1/+1
| | | | ipcp-data was not correctly destroyed.
* lib: Revise blocking I/Odimitri staessens2016-08-031-9/+9
| | | | | | | | | Blocking I/O now uses condition variables in the shared memory instead of busy waiting. Timeouts can be specified. This requires the size of the rbuffs and du_map to be the same, to guarantee that when the shm_du_map is not full, the ap_rbuffs can't be full either. Added the timeout option to the flow for future use.
* shim-eth-llc: Fix for bad driversdimitri staessens2016-08-011-75/+79
| | | | | | | | It seems like drivers are setting the Ethernet length field wrong when sending an LLC message. The LLC shim now writes the payload length in the frame to circumvent the wrong information from the driver. Also fixes deallocation.
* lib: Portability to FreeBSDdimitri staessens2016-07-291-6/+73
| | | | | | | | | | Various portability fixes for FreeBSD. POSIX requires shm file names to start with a "/" to be portable. lseek(2) can be undefined on POSIX shm, replaced with ftruncate(2). IRMd check on existing lockfile more portable. FreeBSD 11.0 is preferred as it natively supports robust mutexes. Full working LLC implementation pending.
* ipcpd: shim-eth-llc: Use correct frame lengthSander Vrijders2016-07-281-1/+15
| | | | | | | | Upon receipt of a frame, the minimum of the length reported in the frame and the frame length reported by kernel is taken. Some device drivers change the length in the frame. Some others add padding, making the length reported by the kernel too high. This is a lousy workaround to make it work on as many systems as possible.
* build: Fix wrong inclusionSander Vrijders2016-07-261-2/+0
| | | | | | The protobuf include directory was not being correctly handed to the compiler when building. Now the include directory is added project-wide. And the protobuf package is searched for only once.
* ipcpd: Deprecate ipcp_reg/ipcp_unregdimitri staessens2016-07-081-2/+0
|
* ouroboros: Use ouroboros errno.hdimitri staessens2016-07-071-1/+1
| | | | | All includes of <errno.h> within ouroboros are replaced with the ouroboros errno.
* irmd, ipcps: Close logfile on exitdimitri staessens2016-07-071-4/+8
| | | | | | | IRMd and ipcps will now close the logfile upon exit. Also corrects exit(1) to exit(EXIT_FAILURE) and exit(0) to exit(EXIT_SUCCESS).
* Merge branch 'be' of bitbucket.org:ouroboros-rina/ouroboros into be-clean-exitdimitri staessens2016-07-061-2/+2
|\
| * lib, irmd, ipcpd: Provide the feature to write to logsSander Vrijders2016-07-061-2/+2
| | | | | | | | | | | | | | | | | | | | Writing output to log files is now enabled by default. Logs are written to <INSTALL_PREFIX>/var/log/ouroboros, which is created on install. There is a log file for the irmd and one per IPCP. To still get (colored) output on stdout, provide the --stdout switch when starting the irmd. Fixes #17
* | lib: shm_du_map: Clean sdus upon exitdimitri staessens2016-07-061-1/+1
|/ | | | | | | | When an application closes the shm_du_map, it will clean all remaining sdu's for that application. Adds a function to clean the shm_du_map on close. Fixes #20.
* lib: robust locking in shared memory and crash recoverydimitri staessens2016-07-021-9/+10
| | | | | | | | | | | | | | This PR enhances the shared memory providing recovery if a process crashes. It adds a SHM_DU_TIMEOUT_MICROS variable, setting an expiration time for SDU's when shared memory is full. If an application doesn't read a blocking SDU within this time, the shared memory will be cleansed of all SDU's for this application and the application's rbuff will be cleared. Some refactoring of the API's. Fixed wrong pthread checks in IRMd. Fixes #13 Fixes #14
* lib, irmd, ipcpd: Change pid to apiSander Vrijders2016-06-281-8/+8
| | | | Changes the variable name as well to API instead of PID.
* lib, irmd, ipcpd: Change of IRM APISander Vrijders2016-06-281-5/+1
| | | | | | | | | | | | | | This changes the IRM API after discussions with Dimitri. The register operation is now split into a bind and register operation. The same for unregister; unbind and unregister. PIDs are now used as the application instance name. A name for a PID is only provided for scriptability in bash. It is therefore also no longer passed down to the IPCP. Every operation on an IPCP through the IRM API has to use the PID. Quering of the PIDs by name is possible. The IRM tool has been updated to use this new API as well. A subcommand 'ipcp' has been added for operations that take effect on IPCPs only. Fixes #12
* build: correct sandboxingdimitri staessens2016-06-271-1/+1
| | | | | paths cannot start with "/" or PREFIX will be omitted. PREFIX must be set before the project() call.
* build: Fix installation prefixSander Vrijders2016-06-271-1/+1
| | | | | | The installation prefix was taking a trailing backslash, while it is common not to do so. Fixed it so that any trailing backslash is removed by the compilation and installation scripts.
* lib, irmd, ipcp: robust mutexesdimitri staessens2016-06-211-93/+94
| | | | | | | | Update to POSIX 200112L to allow use of robust mutexes in the shm_du_map. Removed the implementation of the rw_lock in favor of pthread_rwlock_t. Placeholder for the shm_du_map_sanitize function.
* Merge remote-tracking branch 'upstream/be' into beSander Vrijders2016-06-201-22/+183
|\
| * ipcpd: Adds RX_RING and TX_RING in shim-eth-llcSander Vrijders2016-06-201-22/+183
| | | | | | | | | | | | | | | | | | | | | | This adds the RX_RING and TX_RING socket options to the shim-eth-llc for faster transmission and reception. On systems where these options are not available the old method of sending and receiving is used. Further optimization would be creating and assigning a read/write thread per CPU core, but that becomes very platform specific, and is not required in the short term. Fixes #10
* | build: Change install directories and set correct permissionsSander Vrijders2016-06-201-1/+1
|/ | | | | | | | | This sets the correct install directories for all the binaries, library and header files. It also sets the right permissions on the sockets and shared memory so that regular users can also use the ouroboros library. Root privileges are required to run the irmd. Fixes #7
* ipcpd: Fix wrong length in shim-eth-llcSander Vrijders2016-06-141-4/+7
| | | | | | | The shim Ethernet with LLC was using the frame length in the header of the 802.3 frame, which contained a wrong value when sent over the wire. Probably the kernel filled in a wrong value. Now it uses the length as reported by recv.
* ipcpd: Remove source AP name from protobuf messageSander Vrijders2016-06-141-5/+4
| | | | | The source AP name was still present in the protobuf message the shim-eth-llc uses.
* ipcpd: Remove source AP name from shim-eth-llcSander Vrijders2016-06-141-9/+2
| | | | | This removes the source AP name from all shim-eth-llc flow allocation operations, since it was removed from flow allocation by 6271d09bd.
* ipcpd: Address comments by DimitriSander Vrijders2016-06-141-30/+23
| | | | | This addresses some comments Dimitri had on the shim Ethernet with LLC.