summaryrefslogtreecommitdiff
path: root/src/ipcpd/normal
Commit message (Collapse)AuthorAgeFilesLines
...
* ipcpd: normal: Add missing else clauseSander Vrijders2017-04-052-10/+7
| | | | | A missing else clause was missing in the fast path, causing the PCI to be shrunk when it should not be. A double free has also been fixed.
* ipcpd: Add lock for allocation requestsSander Vrijders2017-04-051-0/+3
| | | | | This adds a lock to prevent a race condition between flow_req_arr and flow_alloc_resp.
* ipcpd: Revert timeout in fmgrdimitri staessens2017-04-011-6/+1
| | | | | | | Since there are no SDUs on most QoS cubes, the fmgr was always timing out on most QoS cubes, causing considerable delays in most SDUs. The timeout was reset to a very small value (so the bug in glibc 2.25 will cause lockups again).
* ipcpd: Fix CDAP return checks at enrollmentdimitri staessens2017-04-011-4/+4
|
* ipcpd: normal: Fix logsSander Vrijders2017-03-312-11/+6
| | | | | This removes some logs in the graph component and replaces prints of uin64_t variables with an architecture agnostic variant.
* irmd: Keep track of qos in irm_flowdimitri staessens2017-03-311-2/+0
| | | | This fixes the bug in handling multiple concurrent flow allocations.
* Merged in dstaesse/ouroboros/be-new-api (pull request #439)dimitri staessens2017-03-311-13/+2
|\ | | | | | | lib: Revise flow allocation API
| * lib: Revise flow allocation APIdimitri staessens2017-03-311-13/+2
| | | | | | | | | | | | The flow_alloc_res and flow_alloc_resp calls have been removed. The flow_alloc and flow_accept calls are now both blocking and take an additional timeout argument.
* | ipcpd: Add missing lock in normal/neighborsdimitri staessens2017-03-301-3/+4
|/
* ipcpd: normal: Fix cleanup of FRCT instanceSander Vrijders2017-03-301-9/+14
| | | | | The FRCT instance was not properly cleaned when the PFF could not find the next hop.
* ipcpd: normal: Fix enrollment bugSander Vrijders2017-03-301-0/+2
| | | | | | This fixes a bug in enrollment where only the first enrollment would happen correctly since the booleans indicating whether boot, members, and DIF name were sent were not initialized back to false.
* ipcpd: normal: Add graph regression testSander Vrijders2017-03-294-2/+276
| | | | | This adds a regression test for the graph component to test the routing table.
* ipcpd: normal: Make graph undirectedSander Vrijders2017-03-293-7/+37
| | | | | | This turns the directed graph into an undirected one. Only one side of the flow creates an FSDB entry. The graph structure creates an edge object for every vertex involved when an edge is updated or removed.
* ipcpd: Correctly read MGMT type PDUs from rdrbuffdimitri staessens2017-03-281-35/+36
| | | | They were not consumed upon reading, causing the rdrbuff to fill up.
* ipcpd: Fix memleaks in fmgrdimitri staessens2017-03-281-0/+4
|
* ipcpd: Fix use-after-free in frctdimitri staessens2017-03-281-1/+2
|
* ipcpd: normal: Fix invalid free of pciSander Vrijders2017-03-281-5/+0
| | | | | The PCI was being freed by frct, but it was stack memory which was created in the fmgr, resulting in an illegal free.
* ipcpd: normal: Call shm_pci_init on fmgr initSander Vrijders2017-03-283-10/+29
| | | | | | The shm PCI was never initialized during flow manager init. This commit will do that, and initialize the pdu length correctly as well, since it was not being written into the RIB, nor read in shm_pci_init.
* ipcpd: normal: Fix wrong update to indexSander Vrijders2017-03-281-2/+2
| | | | | The index j in the function that transforms the list of predecessors to a routing table was incremented at the wrong time.
* ipcpd: normal: Fix locking of PFFSander Vrijders2017-03-282-19/+10
| | | | | | This adds fixes the locking of the PFF which was externalized, but not yet correctly updated within the PFF component itself and within the flow manager.
* ipcpd: normal: Remove graph_add_edge operationSander Vrijders2017-03-283-73/+33
| | | | | | This removes the graph_add_edge operation of the graph component. The routing component now only listens to RO_MODIFY events, and updates the graph accordingly.
* lib, ipcpd: Fix bugs in ro setsSander Vrijders2017-03-282-8/+10
| | | | | This fixes several bugs in the ro sets, rib. And it fixes several bugs in the graph and routing component of the normal IPCP.
* ipcpd: normal: Fix compilation issueSander Vrijders2017-03-281-1/+1
|
* ipcpd: normal: Avoid double freeSander Vrijders2017-03-253-5/+4
| | | | | The flow manager should clean up the buffer after the call to frct create instance has either failed or succeeded.
* ipcpd: Register nb_notifiers before starting gamdimitri staessens2017-03-251-11/+12
|
* ipcpd: Initial synchronisation of the RIBdimitri staessens2017-03-242-24/+264
|
* ipcpd: normal: Fill in forwarding tableSander Vrijders2017-03-243-6/+61
| | | | | | The routing now takes the results of the routing table to fill in the forwarding table, by going through the neighbors and filling in the right fd.
* ipcpd: normal: Fix bad freeSander Vrijders2017-03-241-12/+12
| | | | | This fixes a bad free. The table was only freed if it was NULL, instead of the other way around.
* ipcpd: normal: Fix negative mallocSander Vrijders2017-03-241-0/+11
| | | | | This adds a check to prevent a negative malloc in case the graph structure is empty.
* ipcpd: normal: Fix while loopSander Vrijders2017-03-241-0/+7
| | | | | The next vertex was not taken at the end of the Dijkstra calculation loop.
* ipcpd: normal: Fix segfault in dijkstra calculationSander Vrijders2017-03-241-1/+2
| | | | | | | This fixes a dumb segfault in the dijkstra calculation. If an entry can be removed from the table it was set to NULL. However, if the table is completely empty, the index was -1, resulting in an illegal access into the table.
* Merged in dstaesse/ouroboros/be-fmgr (pull request #417)dimitri staessens2017-03-231-1/+5
|\ | | | | | | ipcpd: Increase update timeout in fmgr
| * ipcpd: Increase update timeout in fmgrdimitri staessens2017-03-231-1/+5
| | | | | | | | This works around a possible bug in glibc 2.25.
* | ipcpd: normal: Add routing table calculationSander Vrijders2017-03-233-28/+274
| | | | | | | | | | | | This adds routing table calculation to the graph component. The routing instances can then periodically ask the graph component for the routing table, and update their PFFs accordingly.
* | ipcpd: normal: Add memset of conn_infoSander Vrijders2017-03-222-0/+4
|/ | | | | This initializes conn_info in the ribmgr and fmgr before it is passed to cacep.
* ipcpd: Create cdap instance at enroll_initdimitri staessens2017-03-221-14/+18
|
* ipcpd: Fix cleanup handler in connmgrdimitri staessens2017-03-221-2/+4
|
* ipcpd: normal: Fix memory leaksSander Vrijders2017-03-223-0/+6
| | | | This fixes some memleaks as reported by valgrind.
* ipcpd: normal: Initialize qosspecSander Vrijders2017-03-221-0/+2
| | | | | The QoS spec was not being initialized before being added to the graph structure, resulting in an error when compiled with clang.
* ipcpd: normal: Several bugfixesSander Vrijders2017-03-214-19/+20
| | | | These solve several bugfixes in the normal.
* Merged in sandervrijders/ouroboros/be-fmgr (pull request #406)Sander Vrijders2017-03-215-52/+78
|\ | | | | | | ipcpd: normal: Split fmgr init into init and start
| * ipcpd: normal: Split fmgr init into init and startSander Vrijders2017-03-215-52/+78
| | | | | | | | | | | | This split the initialization of the flow manager into an init part and a start part. This avoids the usage of data structures that have not been properly initialized yet.
* | ipcpd: Fill qosspec in complete gam policydimitri staessens2017-03-211-0/+3
|/ | | | | The temporary cube parameter must be initialized if a qosspec is passed to avoid uninitialized values for the qoscube in the prototype.
* Merged in dstaesse/ouroboros/be-connmgr (pull request #403)dimitri staessens2017-03-203-31/+39
|\ | | | | | | ipcpd: Fix cleanup of connmgr
| * ipcpd: Create CDAP instance before connectingdimitri staessens2017-03-201-11/+12
| | | | | | | | | | This lessens the likelyhood that the CDAP SDU thread is not yet active when a new connection starts sending CDAP messages.
| * ipcpd: Fix cleanup of connmgrdimitri staessens2017-03-202-20/+27
| | | | | | | | Fixed trying to double lock and cleanup order in main.
* | Merged in sandervrijders/ouroboros/be-graph (pull request #402)Sander Vrijders2017-03-206-64/+539
|\ \ | |/ |/| | | Be graph
| * ipcpd: normal: routing: Listen to RIB eventsSander Vrijders2017-03-203-34/+182
| | | | | | | | | | | | This lets the routing component listen to RIB events. It listens to /fsdb which is populated with FSOs. The graph that is kept within the routing component is updated depending on the event that was received.
| * ipcpd: normal: Add graph structureSander Vrijders2017-03-145-38/+365
| | | | | | | | | | | | This adds a graph structure which will be updated by routing when it is notified about a new RIB event. The routing can then use this graph as input for calculating the shortest path to a destination.
* | ipcpd: Fix disregarding qs in connmgrdimitri staessens2017-03-141-2/+5
| |
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-18 06:56:03 +0000