diff options
Diffstat (limited to 'src/ipcpd')
| -rw-r--r-- | src/ipcpd/normal/CMakeLists.txt | 4 | ||||
| -rw-r--r-- | src/ipcpd/normal/addr_auth.c | 44 | ||||
| -rw-r--r-- | src/ipcpd/normal/addr_auth.h | 12 | ||||
| -rw-r--r-- | src/ipcpd/normal/cdap_flow.c | 150 | ||||
| -rw-r--r-- | src/ipcpd/normal/cdap_flow.h | 49 | ||||
| -rw-r--r-- | src/ipcpd/normal/enroll.c | 161 | ||||
| -rw-r--r-- | src/ipcpd/normal/gam.c | 91 | ||||
| -rw-r--r-- | src/ipcpd/normal/main.c | 22 | ||||
| -rw-r--r-- | src/ipcpd/normal/pol-addr-auth-ops.h | 34 | ||||
| -rw-r--r-- | src/ipcpd/normal/pol/flat.c | 10 | ||||
| -rw-r--r-- | src/ipcpd/normal/pol/flat.h | 8 | 
11 files changed, 420 insertions, 165 deletions
| diff --git a/src/ipcpd/normal/CMakeLists.txt b/src/ipcpd/normal/CMakeLists.txt index f2e48cbc..7e10cc0d 100644 --- a/src/ipcpd/normal/CMakeLists.txt +++ b/src/ipcpd/normal/CMakeLists.txt @@ -14,12 +14,12 @@ include_directories(${CMAKE_BINARY_DIR}/include)  set(IPCP_NORMAL_TARGET ipcpd-normal CACHE STRING "IPCP_NORMAL_TARGET") -protobuf_generate_c(FLOW_ALLOC_SRCS FLOW_ALLOC_HDRS -  flow_alloc.proto) +protobuf_generate_c(FLOW_ALLOC_SRCS FLOW_ALLOC_HDRS flow_alloc.proto)  set(SOURCE_FILES    # Add source files here    addr_auth.c +  cdap_flow.c    dir.c    enroll.c    fmgr.c diff --git a/src/ipcpd/normal/addr_auth.c b/src/ipcpd/normal/addr_auth.c index 210744af..8469e95e 100644 --- a/src/ipcpd/normal/addr_auth.c +++ b/src/ipcpd/normal/addr_auth.c @@ -3,7 +3,8 @@   *   * Address authority   * - *    Sander Vrijders <sander.vrijders@intec.ugent.be> + *    Sander Vrijders   <sander.vrijders@intec.ugent.be> + *    Dimitri Staessens <dimitri.staessens@intec.ugent.be>   *   * This program is free software; you can redistribute it and/or modify   * it under the terms of the GNU General Public License version 2 as @@ -25,47 +26,36 @@  #include <ouroboros/logs.h>  #include "addr_auth.h" +#include "pol-addr-auth-ops.h"  #include "pol/flat.h"  #include <stdlib.h>  #include <assert.h> -struct addr_auth * addr_auth_create(enum pol_addr_auth type) -{ -        struct addr_auth * tmp; - -        tmp = malloc(sizeof(*tmp)); -        if (tmp == NULL) { -                log_err("Failed to malloc addr auth."); -                return NULL; -        } +struct addr_auth { +        struct pol_addr_auth_ops * ops; +} addr_auth; +int addr_auth_init(enum pol_addr_auth type) +{          switch (type) {          case FLAT_RANDOM: -                tmp->address = flat_address; -                tmp->type = type; +                addr_auth.ops = &flat_ops;                  break;          default:                  log_err("Unknown address authority type."); -                free(tmp); -                return NULL; +                return -1;          } -        return tmp; +        return addr_auth.ops->init();  } -int addr_auth_destroy(struct addr_auth * instance) +uint64_t addr_auth_address(void)  { -        assert(instance); - -        switch (instance->type) { -        case FLAT_RANDOM: -                break; -        default: -                log_err("Unknown address authority type."); -        } - -        free(instance); +        return addr_auth.ops->address(); +} -        return 0; +int addr_auth_fini(void) +{ +        return addr_auth.ops->fini();  } diff --git a/src/ipcpd/normal/addr_auth.h b/src/ipcpd/normal/addr_auth.h index 8d67bc66..b389fa90 100644 --- a/src/ipcpd/normal/addr_auth.h +++ b/src/ipcpd/normal/addr_auth.h @@ -3,7 +3,8 @@   *   * Address authority   * - *    Sander Vrijders <sander.vrijders@intec.ugent.be> + *    Sander Vrijders   <sander.vrijders@intec.ugent.be> + *    Dimitri Staessens <dimitri.staessens@intec.ugent.be>   *   * This program is free software; you can redistribute it and/or modify   * it under the terms of the GNU General Public License version 2 as @@ -26,13 +27,10 @@  #include <stdint.h> -struct addr_auth { -        enum pol_addr_auth type; -        uint64_t (* address)(void); -}; +int      addr_auth_init(enum pol_addr_auth type); -struct addr_auth * addr_auth_create(enum pol_addr_auth type); +int      addr_auth_fini(void); -int                addr_auth_destroy(struct addr_auth * instance); +uint64_t addr_auth_address(void);  #endif /* OUROBOROS_IPCPD_NORMAL_ADDR_AUTH_H */ diff --git a/src/ipcpd/normal/cdap_flow.c b/src/ipcpd/normal/cdap_flow.c new file mode 100644 index 00000000..a94627c2 --- /dev/null +++ b/src/ipcpd/normal/cdap_flow.c @@ -0,0 +1,150 @@ +/* + * Ouroboros - Copyright (C) 2016 - 2017 + * + * Normal IPC Process - Authenticated CDAP Flow Allocator + * + *    Sander Vrijders   <sander.vrijders@ugent.be> + *    Dimitri Staessens <dimitri.staessens@ugent.be> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + */ + +#define OUROBOROS_PREFIX "cdap-flow" + +#include <ouroboros/config.h> +#include <ouroboros/dev.h> +#include <ouroboros/logs.h> + +#include "cdap_flow.h" + +#include <stdlib.h> +#include <assert.h> + +static void cdap_flow_destroy(struct cdap_flow * flow) +{ +        assert(flow); + +        if (flow->ci != NULL) +                cdap_destroy(flow->ci); +        if (flow->info != NULL) { +                cacep_info_fini(flow->info); +                free(flow->info); +        } + +        free(flow); +} + +struct cdap_flow * cdap_flow_arr(int                       fd, +                                 int                       resp, +                                 enum pol_cacep            pc, +                                 const struct cacep_info * info) +{ +        struct cdap_flow *  flow; + +        if (flow_alloc_resp(fd, resp) < 0) { +                log_err("Could not respond to new flow."); +                return NULL; +        } + +        if (resp) +                return NULL; + +        flow = malloc(sizeof(*flow)); +        if (flow == NULL) { +                log_err("Failed to malloc."); +                return NULL; +        } + +        flow->fd = fd; +        flow->ci = NULL; + +        flow->info = cacep_auth_wait(fd, pc, info); +        if (flow->info == NULL) { +                log_err("Other side failed to authenticate."); +                cdap_flow_destroy(flow); +                return NULL; +        } + +        flow->ci = cdap_create(fd); +        if (flow->ci == NULL) { +                log_err("Failed to create CDAP instance."); +                cdap_flow_destroy(flow); +                return NULL; +        } + +        return flow; +} + +struct cdap_flow * cdap_flow_alloc(const char *              dst_name, +                                   const char *              ae_name, +                                   qosspec_t *               qs, +                                   enum pol_cacep            pc, +                                   const struct cacep_info * info) +{ +        struct cdap_flow *  flow; +        int                 fd; + +        log_dbg("Allocating flow to %s.", dst_name); + +        if (dst_name == NULL || ae_name == NULL) { +                log_err("Not enough info to establish flow."); +                return NULL; +        } + +        fd = flow_alloc(dst_name, ae_name, qs); +        if (fd < 0) { +                log_err("Failed to allocate flow to %s.", dst_name); +                return NULL; +        } + +        if (flow_alloc_res(fd)) { +                log_err("Flow allocation to %s failed.", dst_name); +                return NULL; +        } + +        flow = malloc(sizeof(*flow)); +        if (flow == NULL) { +                log_err("Failed to malloc."); +                flow_dealloc(fd); +                return NULL; +        } + +        flow->fd = fd; +        flow->ci = NULL; + +        flow->info = cacep_auth(fd, pc, info); +        if (flow->info == NULL) { +                log_err("Failed to authenticate."); +                cdap_flow_dealloc(flow); +                return NULL; +        } + +        flow->ci = cdap_create(fd); +        if (flow->ci == NULL) { +                log_err("Failed to create CDAP instance."); +                cdap_flow_dealloc(flow); +                return NULL; +        } + +        return flow; +} + +void cdap_flow_dealloc(struct cdap_flow * flow) +{ +        int fd = flow->fd; + +        cdap_flow_destroy(flow); + +        flow_dealloc(fd); +} diff --git a/src/ipcpd/normal/cdap_flow.h b/src/ipcpd/normal/cdap_flow.h new file mode 100644 index 00000000..c5ca2ab4 --- /dev/null +++ b/src/ipcpd/normal/cdap_flow.h @@ -0,0 +1,49 @@ +/* + * Ouroboros - Copyright (C) 2016 - 2017 + * + * Normal IPC Process - Authenticated CDAP Flow Allocator + * + *    Sander Vrijders   <sander.vrijders@ugent.be> + *    Dimitri Staessens <dimitri.staessens@ugent.be> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + */ + +#ifndef OUROBOROS_IPCPD_NORMAL_CDAP_FLOW_H +#define OUROBOROS_IPCPD_NORMAL_CDAP_FLOW_H + +#include <ouroboros/cacep.h> +#include <ouroboros/cdap.h> +#include <ouroboros/qos.h> + +struct cdap_flow { +        int                 fd; +        struct cdap *       ci; +        struct cacep_info * info; +}; + +struct cdap_flow * cdap_flow_arr(int                       fd, +                                 int                       resp, +                                 enum pol_cacep            pc, +                                 const struct cacep_info * info); + +struct cdap_flow * cdap_flow_alloc(const char *              dst_name, +                                   const char *              ae_name, +                                   qosspec_t *               qs, +                                   enum pol_cacep            pc, +                                   const struct cacep_info * info); + +void               cdap_flow_dealloc(struct cdap_flow * flow); + +#endif /* OUROBOROS_IPCPD_NORMAL_CDAP_FLOW_H */ diff --git a/src/ipcpd/normal/enroll.c b/src/ipcpd/normal/enroll.c index bc5d2a20..ce6768fb 100644 --- a/src/ipcpd/normal/enroll.c +++ b/src/ipcpd/normal/enroll.c @@ -23,12 +23,13 @@  #include <ouroboros/config.h>  #include <ouroboros/endian.h>  #include <ouroboros/time_utils.h> -#include <ouroboros/cdap.h>  #include <ouroboros/dev.h>  #include <ouroboros/logs.h>  #include <ouroboros/rib.h> +#include <ouroboros/errno.h>  #include "ae.h" +#include "cdap_flow.h"  #include "ribconfig.h"  #include <assert.h> @@ -42,14 +43,15 @@  int enroll_handle(int fd)  { -        struct cdap *    ci; -        cdap_key_t       key; -        enum cdap_opcode oc; -        char *           name; -        uint8_t *        buf; -        uint8_t *        data; -        ssize_t          len; -        uint32_t         flags; +        struct cdap_flow * flow; +        struct cacep_info  info; +        cdap_key_t         key; +        enum cdap_opcode   oc; +        char *             name; +        uint8_t *          buf; +        uint8_t *          data; +        ssize_t            len; +        uint32_t           flags;          bool boot_r     = false;          bool members_r  = false; @@ -59,21 +61,29 @@ int enroll_handle(int fd)          char * members_ro = MEMBERS_PATH;          char * dif_ro     = DIF_PATH; -        if (flow_alloc_resp(fd, 0) < 0) { -                flow_dealloc(fd); -                log_err("Could not respond to request."); -                return -1; +        cacep_info_init(&info); + +        info.proto.protocol = strdup(CDAP_PROTO); +        if (info.proto.protocol == NULL) { +                cacep_info_fini(&info); +                return -ENOMEM;          } -        ci = cdap_create(fd); -        if (ci == NULL) { +        info.proto.pref_version = 1; +        info.proto.pref_syntax  = PROTO_GPB; + +        flow = cdap_flow_arr(fd, 0, ANONYMOUS_AUTH, &info); +        if (flow == NULL) { +                log_err("Failed to auth enrollment request."); +                cacep_info_fini(&info);                  flow_dealloc(fd); -                log_err("Failed to create CDAP instance.");                  return -1;          } +        cacep_info_fini(&info); +          while (!(boot_r && members_r && dif_name_r)) { -                key = cdap_request_wait(ci, &oc, &name, &data, +                key = cdap_request_wait(flow->ci, &oc, &name, &data,                                          (size_t *) &len , &flags);                  assert(key >= 0);                  assert(name); @@ -85,9 +95,8 @@ int enroll_handle(int fd)                  if (oc != CDAP_READ) {                          log_warn("Invalid request."); -                        cdap_reply_send(ci, key, -1, NULL, 0); -                        cdap_destroy(ci); -                        flow_dealloc(fd); +                        cdap_reply_send(flow->ci, key, -1, NULL, 0); +                        cdap_flow_dealloc(flow);                          free(name);                          return -1;                  } @@ -104,14 +113,13 @@ int enroll_handle(int fd)                          clock_gettime(CLOCK_REALTIME, &t);                          buf[0] = hton64(t.tv_sec);                          buf[1] = hton64(t.tv_nsec); -                        cdap_reply_send(ci, key, 0, buf, sizeof(buf)); +                        cdap_reply_send(flow->ci, key, 0, buf, sizeof(buf));                          free(name);                          continue;                  } else {                          log_warn("Illegal read: %s.", name); -                        cdap_reply_send(ci, key, -1, NULL, 0); -                        cdap_destroy(ci); -                        flow_dealloc(fd); +                        cdap_reply_send(flow->ci, key, -1, NULL, 0); +                        cdap_flow_dealloc(flow);                          free(name);                          return -1;                  } @@ -119,9 +127,8 @@ int enroll_handle(int fd)                  len = rib_pack(name, &buf, PACK_HASH_ROOT);                  if (len < 0) {                          log_err("Failed to pack %s.", name); -                        cdap_reply_send(ci, key, -1, NULL, 0); -                        cdap_destroy(ci); -                        flow_dealloc(fd); +                        cdap_reply_send(flow->ci, key, -1, NULL, 0); +                        cdap_flow_dealloc(flow);                          free(name);                          return -1;                  } @@ -130,10 +137,9 @@ int enroll_handle(int fd)                  free(name); -                if (cdap_reply_send(ci, key, 0, buf, len)) { +                if (cdap_reply_send(flow->ci, key, 0, buf, len)) {                          log_err("Failed to send CDAP reply."); -                        cdap_destroy(ci); -                        flow_dealloc(fd); +                        cdap_flow_dealloc(flow);                          return -1;                  } @@ -142,20 +148,18 @@ int enroll_handle(int fd)          log_dbg("Sent boot info to new member."); -        cdap_destroy(ci); - -        flow_dealloc(fd); +        cdap_flow_dealloc(flow);          return 0;  }  int enroll_boot(char * dst_name)  { -        struct cdap * ci; -        cdap_key_t    key; -        uint8_t *     data; -        size_t        len; -        int           fd; +        struct cdap_flow * flow; +        struct cacep_info  info; +        cdap_key_t         key; +        uint8_t *          data; +        size_t             len;          struct timespec t0;          struct timespec rtt; @@ -166,41 +170,41 @@ int enroll_boot(char * dst_name)          char * members_ro = MEMBERS_PATH;          char * dif_ro     = DIF_PATH; -        fd = flow_alloc(dst_name, ENROLL_AE, NULL); -        if (fd < 0) { -                log_err("Failed to allocate flow."); -                return -1; -        } +        cacep_info_init(&info); -        if (flow_alloc_res(fd)) { -                log_err("Flow allocation failed."); -                flow_dealloc(fd); -                return -1; +        info.proto.protocol = strdup(CDAP_PROTO); +        if (info.proto.protocol == NULL) { +                cacep_info_fini(&info); +                return -ENOMEM;          } -        ci = cdap_create(fd); -        if (ci == NULL) { -                log_err("Failed to create CDAP instance."); -                flow_dealloc(fd); +        info.proto.pref_version = 1; +        info.proto.pref_syntax  = PROTO_GPB; + +        flow = cdap_flow_alloc(dst_name, ENROLL_AE, NULL, ANONYMOUS_AUTH, +                               &info); +        if (flow == NULL) { +                log_err("Failed to allocate flow for enrollment request."); +                cacep_info_fini(&info);                  return -1;          } +        cacep_info_fini(&info); +          log_dbg("Getting boot information from %s.", dst_name);          clock_gettime(CLOCK_REALTIME, &t0); -        key = cdap_request_send(ci, CDAP_READ, TIME_PATH, NULL, 0, 0); +        key = cdap_request_send(flow->ci, CDAP_READ, TIME_PATH, NULL, 0, 0);          if (key < 0) {                  log_err("Failed to send CDAP request."); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          } -        if (cdap_reply_wait(ci, key, &data, &len)) { +        if (cdap_reply_wait(flow->ci, key, &data, &len)) {                  log_err("Failed to get CDAP reply."); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          } @@ -218,18 +222,16 @@ int enroll_boot(char * dst_name)          free(data); -        key = cdap_request_send(ci, CDAP_READ, boot_ro, NULL, 0, 0); +        key = cdap_request_send(flow->ci, CDAP_READ, boot_ro, NULL, 0, 0);          if (key < 0) {                  log_err("Failed to send CDAP request."); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          } -        if (cdap_reply_wait(ci, key, &data, &len)) { +        if (cdap_reply_wait(flow->ci, key, &data, &len)) {                  log_err("Failed to get CDAP reply."); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          } @@ -239,25 +241,22 @@ int enroll_boot(char * dst_name)                  log_warn("Error unpacking RIB data.");                  rib_del(boot_ro);                  free(data); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          }          log_dbg("Packed information inserted into RIB."); -        key = cdap_request_send(ci, CDAP_READ, members_ro, NULL, 0, 0); +        key = cdap_request_send(flow->ci, CDAP_READ, members_ro, NULL, 0, 0);          if (key < 0) {                  log_err("Failed to send CDAP request."); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          } -        if (cdap_reply_wait(ci, key, &data, &len)) { +        if (cdap_reply_wait(flow->ci, key, &data, &len)) {                  log_err("Failed to get CDAP reply."); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          } @@ -267,25 +266,22 @@ int enroll_boot(char * dst_name)                  log_warn("Error unpacking RIB data.");                  rib_del(boot_ro);                  free(data); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          }          log_dbg("Packed information inserted into RIB."); -        key = cdap_request_send(ci, CDAP_READ, dif_ro, NULL, 0, 0); +        key = cdap_request_send(flow->ci, CDAP_READ, dif_ro, NULL, 0, 0);          if (key < 0) {                  log_err("Failed to send CDAP request."); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          } -        if (cdap_reply_wait(ci, key, &data, &len)) { +        if (cdap_reply_wait(flow->ci, key, &data, &len)) {                  log_err("Failed to get CDAP reply."); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          } @@ -295,16 +291,13 @@ int enroll_boot(char * dst_name)                  log_warn("Error unpacking RIB data.");                  rib_del(boot_ro);                  free(data); -                cdap_destroy(ci); -                flow_dealloc(fd); +                cdap_flow_dealloc(flow);                  return -1;          }          log_dbg("Packed information inserted into RIB."); -        cdap_destroy(ci); - -        flow_dealloc(fd); +        cdap_flow_dealloc(flow);          return 0;  } diff --git a/src/ipcpd/normal/gam.c b/src/ipcpd/normal/gam.c index 9ee55261..791cf34e 100644 --- a/src/ipcpd/normal/gam.c +++ b/src/ipcpd/normal/gam.c @@ -23,6 +23,7 @@  #define OUROBOROS_PREFIX "graph-adjacency-manager"  #include <ouroboros/config.h> +#include <ouroboros/cdap.h>  #include <ouroboros/dev.h>  #include <ouroboros/logs.h>  #include <ouroboros/list.h> @@ -178,8 +179,8 @@ int gam_flow_arr(struct gam * instance,                   int          fd,                   qosspec_t    qs)  { -        struct cacep *      cacep; -        struct cacep_info * info; +        struct cacep_info * rcv_info; +        struct cacep_info   snd_info;          if (flow_alloc_resp(fd, instance->ops->accept_new_flow(instance->ops_o))              < 0) { @@ -187,32 +188,43 @@ int gam_flow_arr(struct gam * instance,                  return -1;          } -        cacep = cacep_create(fd, ipcpi.name, ipcpi.address); -        if (cacep == NULL) { -                log_err("Failed to create CACEP instance."); -                return -1; +        cacep_info_init(&snd_info); +        snd_info.proto.protocol = strdup(CDAP_PROTO); +        if (snd_info.proto.protocol == NULL) { +                cacep_info_fini(&snd_info); +                return -ENOMEM; +        } + +        snd_info.proto.pref_version = 1; +        snd_info.proto.pref_syntax = PROTO_GPB; +        snd_info.addr = ipcpi.address; +        snd_info.name = strdup(ipcpi.name); +        if (snd_info.name == NULL) { +                cacep_info_fini(&snd_info); +                return -ENOMEM;          } -        info = cacep_auth_wait(cacep); -        if (info == NULL) { +        rcv_info = cacep_auth_wait(fd, SIMPLE_AUTH, &snd_info); +        if (rcv_info == NULL) {                  log_err("Other side failed to authenticate."); -                cacep_destroy(cacep); +                cacep_info_fini(&snd_info);                  return -1;          } -        cacep_destroy(cacep); +        cacep_info_fini(&snd_info); -        if (instance->ops->accept_flow(instance->ops_o, qs, info)) { +        if (instance->ops->accept_flow(instance->ops_o, qs, rcv_info)) {                  flow_dealloc(fd); -                free(info->name); -                free(info); +                cacep_info_fini(rcv_info); +                free(rcv_info);                  return 0;          } -        if (add_ga(instance, fd, qs, info)) { +        if (add_ga(instance, fd, qs, rcv_info)) {                  log_err("Failed to add ga to graph adjacency manager list."); -                free(info->name); -                free(info); +                flow_dealloc(fd); +                cacep_info_fini(rcv_info); +                free(rcv_info);                  return -1;          } @@ -223,10 +235,12 @@ int gam_flow_alloc(struct gam * instance,                     char *       dst_name,                     qosspec_t    qs)  { -        struct cacep *      cacep; -        struct cacep_info * info; +        struct cacep_info * rcv_info; +        struct cacep_info   snd_info;          int                 fd; +        log_dbg("Allocating flow to %s.", dst_name); +          fd = flow_alloc(dst_name, instance->ae_name, NULL);          if (fd < 0) {                  log_err("Failed to allocate flow to %s.", dst_name); @@ -239,32 +253,43 @@ int gam_flow_alloc(struct gam * instance,                  return -1;          } -        cacep = cacep_create(fd, ipcpi.name, ipcpi.address); -        if (cacep == NULL) { -                log_err("Failed to create CACEP instance."); -                return -1; +        cacep_info_init(&snd_info); +        snd_info.proto.protocol = strdup(CDAP_PROTO); +        if (snd_info.proto.protocol == NULL) { +                cacep_info_fini(&snd_info); +                return -ENOMEM; +        } + +        snd_info.proto.pref_version = 1; +        snd_info.proto.pref_syntax = PROTO_GPB; +        snd_info.addr = ipcpi.address; +        snd_info.name = strdup(ipcpi.name); +        if (snd_info.name == NULL) { +                cacep_info_fini(&snd_info); +                return -ENOMEM;          } -        info = cacep_auth(cacep); -        if (info == NULL) { -                log_err("Failed to authenticate."); -                cacep_destroy(cacep); +        rcv_info = cacep_auth(fd, SIMPLE_AUTH, &snd_info); +        if (rcv_info == NULL) { +                log_err("Other side failed to authenticate."); +                cacep_info_fini(&snd_info);                  return -1;          } -        cacep_destroy(cacep); +        cacep_info_fini(&snd_info); -        if (instance->ops->accept_flow(instance->ops_o, qs, info)) { +        if (instance->ops->accept_flow(instance->ops_o, qs, rcv_info)) {                  flow_dealloc(fd); -                free(info->name); -                free(info); +                cacep_info_fini(rcv_info); +                free(rcv_info);                  return 0;          } -        if (add_ga(instance, fd, qs, info)) { +        if (add_ga(instance, fd, qs, rcv_info)) {                  log_err("Failed to add GA to graph adjacency manager list."); -                free(info->name); -                free(info); +                flow_dealloc(fd); +                cacep_info_fini(rcv_info); +                free(rcv_info);                  return -1;          } diff --git a/src/ipcpd/normal/main.c b/src/ipcpd/normal/main.c index c41b6187..522daa3b 100644 --- a/src/ipcpd/normal/main.c +++ b/src/ipcpd/normal/main.c @@ -54,7 +54,6 @@  struct {          pthread_t acceptor; -        struct addr_auth * auth;  } normal;  void ipcp_sig_handler(int         sig, @@ -167,16 +166,15 @@ static int boot_components(void)                  return -1;          } -        normal.auth = addr_auth_create(pa); -        if (normal.auth == NULL) { +        if (addr_auth_init(pa)) {                  log_err("Failed to init address authority.");                  return -1;          } -        ipcpi.address = normal.auth->address(); +        ipcpi.address = addr_auth_address();          if (ipcpi.address == 0) {                  log_err("Failed to get a valid address."); -                addr_auth_destroy(normal.auth); +                addr_auth_fini();                  return -1;          } @@ -186,14 +184,14 @@ static int boot_components(void)          if (ribmgr_init()) {                  log_err("Failed to initialize RIB manager."); -                addr_auth_destroy(normal.auth); +                addr_auth_fini();                  return -1;          }          if (dir_init()) {                  log_err("Failed to initialize directory.");                  ribmgr_fini(); -                addr_auth_destroy(normal.auth); +                addr_auth_fini();                  return -1;          } @@ -202,7 +200,7 @@ static int boot_components(void)          if (fmgr_init()) {                  dir_fini();                  ribmgr_fini(); -                addr_auth_destroy(normal.auth); +                addr_auth_fini();                  log_err("Failed to start flow manager.");                  return -1;          } @@ -211,7 +209,7 @@ static int boot_components(void)                  fmgr_fini();                  dir_fini();                  ribmgr_fini(); -                addr_auth_destroy(normal.auth); +                addr_auth_fini();                  log_err("Failed to initialize FRCT.");                  return -1;          } @@ -223,7 +221,7 @@ static int boot_components(void)                  fmgr_fini();                  dir_fini();                  ribmgr_fini(); -                addr_auth_destroy(normal.auth); +                addr_auth_fini();                  log_err("Failed to create acceptor thread.");                  return -1;          } @@ -244,7 +242,7 @@ void shutdown_components(void)          ribmgr_fini(); -        addr_auth_destroy(normal.auth); +        addr_auth_fini();  }  static int normal_ipcp_enroll(char * dst_name) @@ -340,7 +338,7 @@ int normal_rib_init(void)  static int normal_ipcp_bootstrap(struct dif_config * conf)  {          /* FIXME: get CACEP policies from conf */ -        enum pol_cacep pol = NO_AUTH; +        enum pol_cacep pol = SIMPLE_AUTH;          (void) pol; diff --git a/src/ipcpd/normal/pol-addr-auth-ops.h b/src/ipcpd/normal/pol-addr-auth-ops.h new file mode 100644 index 00000000..25952636 --- /dev/null +++ b/src/ipcpd/normal/pol-addr-auth-ops.h @@ -0,0 +1,34 @@ +/* + * Ouroboros - Copyright (C) 2016 - 2017 + * + * Address authority policy ops + * + *    Dimitri Staessens <dimitri.staessens@intec.ugent.be> + *    Sander Vrijders   <sander.vrijders@intec.ugent.be> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + */ + +#ifndef OUROBOROS_IPCPD_NORMAL_POL_ADDR_AUTH_OPS_H +#define OUROBOROS_IPCPD_NORMAL_POL_ADDR_AUTH_OPS_H + +struct pol_addr_auth_ops { +        int      (* init)(void); + +        int      (* fini)(void); + +        uint64_t (* address)(void); +}; + +#endif /* OUROBOROS_IPCPD_NORMAL_POL_ADDR_AUTH_OPS_H */ diff --git a/src/ipcpd/normal/pol/flat.c b/src/ipcpd/normal/pol/flat.c index d982f5ac..aa0f6c7c 100644 --- a/src/ipcpd/normal/pol/flat.c +++ b/src/ipcpd/normal/pol/flat.c @@ -80,6 +80,16 @@ static int addr_taken(char *  name,  #define INVALID_ADDRESS 0 +int flat_init(void) +{ +        return 0; +} + +int flat_fini(void) +{ +        return 0; +} +  uint64_t flat_address(void)  {          struct timespec t; diff --git a/src/ipcpd/normal/pol/flat.h b/src/ipcpd/normal/pol/flat.h index 73d7de8b..85fe9281 100644 --- a/src/ipcpd/normal/pol/flat.h +++ b/src/ipcpd/normal/pol/flat.h @@ -22,8 +22,16 @@  #ifndef OUROBOROS_IPCPD_NORMAL_FLAT_H  #define OUROBOROS_IPCPD_NORMAL_FLAT_H +#include "pol-addr-auth-ops.h" +  int      flat_init(void);  int      flat_fini(void);  uint64_t flat_address(void); +struct pol_addr_auth_ops flat_ops = { +        .init    = flat_init, +        .fini    = flat_fini, +        .address = flat_address +}; +  #endif /* OUROBOROS_IPCPD_NORMAL_FLAT_H */ | 
