diff options
Diffstat (limited to 'src/ipcpd/shim-udp')
| -rw-r--r-- | src/ipcpd/shim-udp/main.c | 140 | 
1 files changed, 70 insertions, 70 deletions
| diff --git a/src/ipcpd/shim-udp/main.c b/src/ipcpd/shim-udp/main.c index 8d9ac25c..672941da 100644 --- a/src/ipcpd/shim-udp/main.c +++ b/src/ipcpd/shim-udp/main.c @@ -154,7 +154,7 @@ void shim_ap_fini()          if (_ap_instance == NULL)                  return; -        pthread_rwlock_wrlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          if (_ipcp->state != IPCP_SHUTDOWN)                  LOG_WARN("Cleaning up AP while not in shutdown."); @@ -173,7 +173,7 @@ void shim_ap_fini()                          shm_ap_rbuff_close(_ap_instance->flows[i].rb);          pthread_rwlock_unlock(&_ap_instance->flows_lock); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          free(_ap_instance);  } @@ -197,10 +197,10 @@ static ssize_t ipcp_udp_flow_write(int fd, void * buf, size_t count)          ssize_t index;          struct rb_entry e; -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          if (_ipcp->state != IPCP_ENROLLED) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  return -1; /* -ENOTENROLLED */          } @@ -221,7 +221,7 @@ static ssize_t ipcp_udp_flow_write(int fd, void * buf, size_t count)                  ;          pthread_rwlock_unlock(&_ap_instance->flows_lock); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          return 0;  } @@ -463,7 +463,7 @@ static int ipcp_udp_port_req(struct sockaddr_in * c_saddr,                  return -1;          } -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          pthread_rwlock_wrlock(&_ap_instance->flows_lock);          /* reply to IRM */ @@ -473,7 +473,7 @@ static int ipcp_udp_port_req(struct sockaddr_in * c_saddr,          if (port_id < 0) {                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_ERR("Could not get port id from IRMd");                  close(fd);                  return -1; @@ -484,7 +484,7 @@ static int ipcp_udp_port_req(struct sockaddr_in * c_saddr,          _ap_instance->flows[fd].state   = FLOW_PENDING;          pthread_rwlock_unlock(&_ap_instance->flows_lock); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          LOG_DBG("Pending allocation request, port_id %d, UDP port (%d, %d).",                  port_id, ntohs(f_saddr.sin_port), ntohs(c_saddr->sin_port)); @@ -506,20 +506,20 @@ static int ipcp_udp_port_alloc_reply(int src_udp_port,          LOG_DBG("Received reply for flow on udp port %d.",                  ntohs(dst_udp_port)); -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          pthread_rwlock_rdlock(&_ap_instance->flows_lock);          fd = udp_port_to_fd(dst_udp_port);          if (fd == -1) {                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Unknown flow on UDP port %d.", ntohs(dst_udp_port));                  return -1; /* -EUNKNOWNFLOW */          }          if (_ap_instance->flows[fd].state != FLOW_PENDING) {                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Flow on UDP port %d not pending.",                           ntohs(dst_udp_port));                  return -1; /* -EFLOWNOTPENDING */ @@ -538,7 +538,7 @@ static int ipcp_udp_port_alloc_reply(int src_udp_port,                                  (struct sockaddr *) &t_saddr,                                  &t_saddr_len) < 0) {                          pthread_rwlock_unlock(&_ap_instance->flows_lock); -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          LOG_DBG("Flow with port_id %d has no peer.", port_id);                          return -1;                  } @@ -550,7 +550,7 @@ static int ipcp_udp_port_alloc_reply(int src_udp_port,                              (struct sockaddr *) &t_saddr,                              sizeof(t_saddr)) < 0) {                          pthread_rwlock_unlock(&_ap_instance->flows_lock); -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          close(fd);                          return -1;                  } @@ -559,7 +559,7 @@ static int ipcp_udp_port_alloc_reply(int src_udp_port,          }          pthread_rwlock_unlock(&_ap_instance->flows_lock); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          if ((ret = ipcp_flow_alloc_reply(getpid(), @@ -582,13 +582,13 @@ static int ipcp_udp_flow_dealloc_req(int udp_port)          struct shm_ap_rbuff * rb; -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          pthread_rwlock_rdlock(&_ap_instance->flows_lock);          fd = udp_port_to_fd(udp_port);          if (fd < 0) {                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Could not find flow on UDP port %d.",                           ntohs(udp_port));                  return 0; @@ -610,7 +610,7 @@ static int ipcp_udp_flow_dealloc_req(int udp_port)          if (rb != NULL)                  shm_ap_rbuff_close(rb); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          ipcp_flow_dealloc(0, port_id); @@ -632,16 +632,16 @@ static void * ipcp_udp_listener()                  int sfd = 0;                  shim_udp_msg_t * msg = NULL; -                pthread_rwlock_rdlock(&_ipcp->state_lock); +                pthread_mutex_lock(&_ipcp->state_lock);                  if (_ipcp->state != IPCP_ENROLLED) { -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          return (void *) 1; /* -ENOTENROLLED */                  }                  sfd = shim_data(_ipcp)->s_fd; -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  memset(&buf, 0, SHIM_UDP_MSG_SIZE);                  n = sizeof(c_saddr); @@ -705,10 +705,10 @@ static void * ipcp_udp_sdu_reader()          while (true) {                  struct timeval tv = {0, FD_UPDATE_TIMEOUT}; -                pthread_rwlock_rdlock(&_ipcp->state_lock); +                pthread_mutex_lock(&_ipcp->state_lock);                  if (_ipcp->state != IPCP_ENROLLED) { -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          return (void *) 1; /* -ENOTENROLLED */                  } @@ -721,7 +721,7 @@ static void * ipcp_udp_sdu_reader()                  pthread_mutex_unlock(&_ap_instance->fd_set_lock);                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  if (select(FD_SETSIZE, &read_fds, NULL, NULL, &tv) <= 0) {                          continue; @@ -765,10 +765,10 @@ static void * ipcp_udp_sdu_loop(void * o)                          continue;                  } -                pthread_rwlock_rdlock(&_ipcp->state_lock); +                pthread_mutex_lock(&_ipcp->state_lock);                  if (_ipcp->state != IPCP_ENROLLED) { -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          return (void *) 1; /* -ENOTENROLLED */                  } @@ -776,7 +776,7 @@ static void * ipcp_udp_sdu_loop(void * o)                                        _ap_instance->dum,                                        e->index);                  if (len <= 0) { -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          free(e);                          continue;                  } @@ -786,7 +786,7 @@ static void * ipcp_udp_sdu_loop(void * o)                  fd = port_id_to_fd(e->port_id);                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  if (fd == -1) {                          free(e); @@ -796,12 +796,12 @@ static void * ipcp_udp_sdu_loop(void * o)                  if (send(fd, buf, len, 0) < 0)                          LOG_ERR("Failed to send SDU."); -                pthread_rwlock_rdlock(&_ipcp->state_lock); +                pthread_mutex_lock(&_ipcp->state_lock);                  if (_ap_instance->dum != NULL)                          shm_du_map_remove(_ap_instance->dum, e->index); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  free(e);          } @@ -824,14 +824,14 @@ void ipcp_sig_handler(int sig, siginfo_t * info, void * c)                          LOG_DBG("Terminating by order of %d. Bye.",                                  info->si_pid); -                        pthread_rwlock_wrlock(&_ipcp->state_lock); +                        pthread_mutex_lock(&_ipcp->state_lock);                          if (_ipcp->state == IPCP_ENROLLED)                                  clean_threads = true;                          _ipcp->state = IPCP_SHUTDOWN; -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          if (clean_threads) {                                  pthread_cancel(_ap_instance->handler); @@ -916,10 +916,10 @@ static int ipcp_udp_bootstrap(struct dif_config * conf)                  return -1;          } -        pthread_rwlock_wrlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          if (_ipcp->state != IPCP_INIT) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_ERR("IPCP in wrong state.");                  close(fd);                  return -1; @@ -947,7 +947,7 @@ static int ipcp_udp_bootstrap(struct dif_config * conf)                         ipcp_udp_sdu_loop,                         NULL); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          LOG_DBG("Bootstrapped shim IPCP over UDP with api %d.",                  getpid()); @@ -1098,16 +1098,16 @@ static int ipcp_udp_name_reg(char * name)                  return -1;          } -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          if (_ipcp->state != IPCP_ENROLLED) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Won't register with non-enrolled IPCP.");                  return -1; /* -ENOTENROLLED */          }          if (ipcp_data_add_reg_entry(_ipcp->data, name)) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_ERR("Failed to add %s to local registry.", name);                  return -1;          } @@ -1117,7 +1117,7 @@ static int ipcp_udp_name_reg(char * name)          dns_addr = shim_data(_ipcp)->dns_addr; -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          if (dns_addr != 0) {                  ip_addr = shim_data(_ipcp)->ip_addr; @@ -1136,14 +1136,14 @@ static int ipcp_udp_name_reg(char * name)                          dnsstr, name, DNS_TTL, ipstr);                  if (ddns_send(cmd)) { -                        pthread_rwlock_rdlock(&_ipcp->state_lock); +                        pthread_mutex_lock(&_ipcp->state_lock);                          ipcp_data_del_reg_entry(_ipcp->data, name); -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          return -1;                  }          }  #else -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);  #endif          LOG_DBG("Registered %s.", name); @@ -1167,17 +1167,17 @@ static int ipcp_udp_name_unreg(char * name)  #ifdef CONFIG_OUROBOROS_ENABLE_DNS          /* unregister application with DNS server */ -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          if (_ipcp->state != IPCP_ENROLLED) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("IPCP is not enrolled");                  return -1; /* -ENOTENROLLED */          }          dns_addr = shim_data(_ipcp)->dns_addr; -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          if (dns_addr != 0) {                  if (inet_ntop(AF_INET, &dns_addr, dnsstr, INET_ADDRSTRLEN) @@ -1191,11 +1191,11 @@ static int ipcp_udp_name_unreg(char * name)          }  #endif -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          ipcp_data_del_reg_entry(_ipcp->data, name); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          return 0;  } @@ -1253,10 +1253,10 @@ static int ipcp_udp_flow_alloc(pid_t         n_api,                  return -1;          } -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          if (_ipcp->state != IPCP_ENROLLED) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Won't allocate flow with non-enrolled IPCP.");                  close(fd);                  return -1; /* -ENOTENROLLED */ @@ -1266,7 +1266,7 @@ static int ipcp_udp_flow_alloc(pid_t         n_api,          dns_addr = shim_data(_ipcp)->dns_addr;          if (dns_addr != 0) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  ip_addr = ddns_resolve(dst_name, dns_addr);                  if (ip_addr == 0) { @@ -1275,9 +1275,9 @@ static int ipcp_udp_flow_alloc(pid_t         n_api,                          return -1;                  } -                pthread_rwlock_rdlock(&_ipcp->state_lock); +                pthread_mutex_lock(&_ipcp->state_lock);                  if (_ipcp->state != IPCP_ENROLLED) { -                        pthread_rwlock_unlock(&_ipcp->state_lock); +                        pthread_mutex_unlock(&_ipcp->state_lock);                          LOG_DBG("Won't allocate flow with non-enrolled IPCP.");                          close(fd);                          return -1; /* -ENOTENROLLED */ @@ -1320,13 +1320,13 @@ static int ipcp_udp_flow_alloc(pid_t         n_api,          pthread_rwlock_unlock(&_ap_instance->flows_lock); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          if (ipcp_udp_port_alloc(ip_addr,                                  f_saddr.sin_port,                                  dst_name,                                  src_ae_name) < 0) { -                pthread_rwlock_rdlock(&_ipcp->state_lock); +                pthread_mutex_lock(&_ipcp->state_lock);                  pthread_rwlock_rdlock(&_ap_instance->flows_lock);                  clr_fd(fd); @@ -1340,7 +1340,7 @@ static int ipcp_udp_flow_alloc(pid_t         n_api,                   _ap_instance->flows[fd].rb     = NULL;                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  close(fd);                  return -1;          } @@ -1363,10 +1363,10 @@ static int ipcp_udp_flow_alloc_resp(pid_t n_api,          if (response)                  return 0; -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          if (_ipcp->state != IPCP_ENROLLED) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("IPCP in wrong state.");                  close(fd);                  return -1; /* -ENOTENROLLED */ @@ -1379,14 +1379,14 @@ static int ipcp_udp_flow_alloc_resp(pid_t n_api,          fd = port_id_to_fd(port_id);          if (fd < 0) {                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Could not find flow with port_id %d.", port_id);                  return -1;          }          if (_ap_instance->flows[fd].state != FLOW_PENDING) {                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Flow was not pending.");                  return -1;          } @@ -1397,7 +1397,7 @@ static int ipcp_udp_flow_alloc_resp(pid_t n_api,                  _ap_instance->flows[fd].state   = FLOW_NULL;                  _ap_instance->flows[fd].port_id = -1;                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  return -1;          } @@ -1420,13 +1420,13 @@ static int ipcp_udp_flow_alloc_resp(pid_t n_api,          set_fd(fd);          pthread_rwlock_unlock(&_ap_instance->flows_lock); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          if (ipcp_udp_port_alloc_resp(r_saddr.sin_addr.s_addr,                                       f_saddr.sin_port,                                       r_saddr.sin_port,                                       response) < 0) { -                pthread_rwlock_rdlock(&_ipcp->state_lock); +                pthread_mutex_lock(&_ipcp->state_lock);                  pthread_rwlock_rdlock(&_ap_instance->flows_lock);                  clr_fd(fd); @@ -1439,7 +1439,7 @@ static int ipcp_udp_flow_alloc_resp(pid_t n_api,                  _ap_instance->flows[fd].rb    = NULL;                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  return -1;          } @@ -1457,13 +1457,13 @@ static int ipcp_udp_flow_dealloc(int port_id)          struct sockaddr_in    r_saddr;          socklen_t             r_saddr_len = sizeof(r_saddr); -        pthread_rwlock_rdlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          pthread_rwlock_rdlock(&_ap_instance->flows_lock);          fd = port_id_to_fd(port_id);          if (fd < 0) {                  pthread_rwlock_unlock(&_ap_instance->flows_lock); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Could not find flow with port_id %d.", port_id);                  return 0;          } @@ -1484,7 +1484,7 @@ static int ipcp_udp_flow_dealloc(int port_id)                  shm_ap_rbuff_close(rb);          if (getpeername(fd, (struct sockaddr *) &r_saddr, &r_saddr_len) < 0) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  LOG_DBG("Flow with port_id %d has no peer.", port_id);                  close(fd);                  return 0; @@ -1494,7 +1494,7 @@ static int ipcp_udp_flow_dealloc(int port_id)          r_saddr.sin_port = LISTEN_PORT;          if (connect(fd, (struct sockaddr *) &r_saddr, sizeof(r_saddr)) < 0) { -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  close(fd);                  return 0 ;          } @@ -1502,12 +1502,12 @@ static int ipcp_udp_flow_dealloc(int port_id)          if (ipcp_udp_port_dealloc(r_saddr.sin_addr.s_addr,                                    remote_udp) < 0) {                  LOG_DBG("Could not notify remote."); -                pthread_rwlock_unlock(&_ipcp->state_lock); +                pthread_mutex_unlock(&_ipcp->state_lock);                  close(fd);                  return 0;          } -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          close(fd); @@ -1599,7 +1599,7 @@ int main(int argc, char * argv[])                  exit(EXIT_FAILURE);          } -        pthread_rwlock_wrlock(&_ipcp->state_lock); +        pthread_mutex_lock(&_ipcp->state_lock);          pthread_sigmask(SIG_BLOCK, &sigset, NULL); @@ -1607,7 +1607,7 @@ int main(int argc, char * argv[])          pthread_sigmask(SIG_UNBLOCK, &sigset, NULL); -        pthread_rwlock_unlock(&_ipcp->state_lock); +        pthread_mutex_unlock(&_ipcp->state_lock);          if (ipcp_create_r(getpid())) {                  LOG_ERR("Failed to notify IRMd we are initialized."); | 
