diff options
Diffstat (limited to 'src/ipcpd/shim-eth-llc')
| -rw-r--r-- | src/ipcpd/shim-eth-llc/main.c | 30 | 
1 files changed, 21 insertions, 9 deletions
| diff --git a/src/ipcpd/shim-eth-llc/main.c b/src/ipcpd/shim-eth-llc/main.c index 0d4c3903..3f3c0e1e 100644 --- a/src/ipcpd/shim-eth-llc/main.c +++ b/src/ipcpd/shim-eth-llc/main.c @@ -624,18 +624,22 @@ static void * eth_llc_ipcp_sdu_writer(void * o)          (void) o; -        while (true) { -                if (flow_event_wait(eth_llc_data.np1_flows, -                                    eth_llc_data.fq, -                                    &timeout) == -ETIMEDOUT) -                        continue; +        while (flow_event_wait(eth_llc_data.np1_flows, +                               eth_llc_data.fq, +                               &timeout)) { +                pthread_rwlock_rdlock(&ipcpi.state_lock); + +                if (ipcp_get_state() != IPCP_ENROLLED) { +                        pthread_rwlock_unlock(&ipcpi.state_lock); +                        return (void *) -1; /* -ENOTENROLLED */ +                }                  while ((fd = fqueue_next(eth_llc_data.fq)) >= 0) {                          if (ipcp_flow_read(fd, &sdb)) {                                  LOG_ERR("Bad read from fd %d.", fd);                                  continue;                          } -                        pthread_rwlock_rdlock(&ipcpi.state_lock); +                          pthread_rwlock_rdlock(ð_llc_data.flows_lock);                          ssap = reverse_bits(eth_llc_data.fd_to_ef[fd].sap); @@ -645,7 +649,6 @@ static void * eth_llc_ipcp_sdu_writer(void * o)                                 MAC_SIZE);                          pthread_rwlock_unlock(ð_llc_data.flows_lock); -                        pthread_rwlock_unlock(&ipcpi.state_lock);                          eth_llc_ipcp_send_frame(r_addr, dsap, ssap,                                                  shm_du_buff_head(sdb), @@ -653,6 +656,8 @@ static void * eth_llc_ipcp_sdu_writer(void * o)                                                  - shm_du_buff_head(sdb));                          ipcp_flow_del(sdb);                  } + +                pthread_rwlock_unlock(&ipcpi.state_lock);          }          return (void *) 1; @@ -1045,6 +1050,13 @@ static int eth_llc_ipcp_flow_dealloc(int fd)          ipcp_flow_fini(fd);          pthread_rwlock_rdlock(&ipcpi.state_lock); + +        if (ipcp_get_state() != IPCP_ENROLLED) { +                pthread_rwlock_unlock(&ipcpi.state_lock); +                LOG_DBG("Won't register with non-enrolled IPCP."); +                return -1; /* -ENOTENROLLED */ +        } +          pthread_rwlock_wrlock(ð_llc_data.flows_lock);          flow_set_del(eth_llc_data.np1_flows, fd); @@ -1058,11 +1070,11 @@ static int eth_llc_ipcp_flow_dealloc(int fd)          eth_llc_data.ef_to_fd[sap] = -1; +        flow_dealloc(fd); +          pthread_rwlock_unlock(ð_llc_data.flows_lock);          pthread_rwlock_unlock(&ipcpi.state_lock); -        flow_dealloc(fd); -          LOG_DBG("Flow with fd %d deallocated.", fd);          return 0; | 
