diff options
author | Dimitri Staessens <dimitri.staessens@ugent.be> | 2018-03-22 11:02:15 +0100 |
---|---|---|
committer | Sander Vrijders <sander.vrijders@ugent.be> | 2018-03-22 12:36:58 +0100 |
commit | 751fb58bcf5fdb31c0627a5153684e96126cffb6 (patch) | |
tree | 5c4e8d8b2b2b323738703644c422a7e6c7095d5e /src/irmd | |
parent | fd5508b8daec47e9f646c086d4cc310583154b97 (diff) | |
download | ouroboros-751fb58bcf5fdb31c0627a5153684e96126cffb6.tar.gz ouroboros-751fb58bcf5fdb31c0627a5153684e96126cffb6.zip |
lib: Simplify reg/unreg API
The reg/unreg API is simplified to registering and unregistering a
single name with a single IPCP. The functionality associated with
registering names was moved from the IRMd to the irm tool. The
function to list IPCPs was simplified to return all IPCPs in the
system with their basic properties needed for management.
The above changes led to some needed changes in the irm tool and the
management functions that were depending on the previous behaviour of
list_ipcps.
Command line functionality to list IPCPs in the system is also added
to the irm tool.
Some older code was refactored.
Signed-off-by: Dimitri Staessens <dimitri.staessens@ugent.be>
Signed-off-by: Sander Vrijders <sander.vrijders@ugent.be>
Diffstat (limited to 'src/irmd')
-rw-r--r-- | src/irmd/ipcp.c | 24 | ||||
-rw-r--r-- | src/irmd/main.c | 769 | ||||
-rw-r--r-- | src/irmd/proc_table.c | 2 | ||||
-rw-r--r-- | src/irmd/prog_table.c | 4 | ||||
-rw-r--r-- | src/irmd/registry.c | 31 | ||||
-rw-r--r-- | src/irmd/registry.h | 2 | ||||
-rw-r--r-- | src/irmd/utils.c | 71 | ||||
-rw-r--r-- | src/irmd/utils.h | 8 |
8 files changed, 437 insertions, 474 deletions
diff --git a/src/irmd/ipcp.c b/src/irmd/ipcp.c index efb5fbf3..49bf13c9 100644 --- a/src/irmd/ipcp.c +++ b/src/irmd/ipcp.c @@ -253,8 +253,8 @@ int ipcp_enroll(pid_t pid, if (dst == NULL) return -EINVAL; - msg.code = IPCP_MSG_CODE__IPCP_ENROLL; - msg.dst_name = (char *) dst; + msg.code = IPCP_MSG_CODE__IPCP_ENROLL; + msg.dst = (char *) dst; recv_msg = send_recv_ipcp_msg(pid, &msg); if (recv_msg == NULL) @@ -292,11 +292,11 @@ int ipcp_connect(pid_t pid, ipcp_msg_t * recv_msg = NULL; int ret = -1; - msg.code = IPCP_MSG_CODE__IPCP_CONNECT; - msg.dst_name = (char *) dst; - msg.comp_name = (char *) component; - msg.has_pid = true; - msg.pid = pid; + msg.code = IPCP_MSG_CODE__IPCP_CONNECT; + msg.dst = (char *) dst; + msg.comp = (char *) component; + msg.has_pid = true; + msg.pid = pid; recv_msg = send_recv_ipcp_msg(pid, &msg); if (recv_msg == NULL) @@ -321,11 +321,11 @@ int ipcp_disconnect(pid_t pid, ipcp_msg_t * recv_msg = NULL; int ret = -1; - msg.code = IPCP_MSG_CODE__IPCP_DISCONNECT; - msg.dst_name = (char *) dst; - msg.comp_name = (char *) component; - msg.has_pid = true; - msg.pid = pid; + msg.code = IPCP_MSG_CODE__IPCP_DISCONNECT; + msg.dst = (char *) dst; + msg.comp = (char *) component; + msg.has_pid = true; + msg.pid = pid; recv_msg = send_recv_ipcp_msg(pid, &msg); if (recv_msg == NULL) diff --git a/src/irmd/main.c b/src/irmd/main.c index 411df6dd..e90cbbc8 100644 --- a/src/irmd/main.c +++ b/src/irmd/main.c @@ -83,11 +83,11 @@ struct ipcp_entry { pid_t pid; enum ipcp_type type; enum hash_algo dir_hash_algo; - char * layer_name; + char * layer; - enum init_state init_state; - pthread_cond_t init_cond; - pthread_mutex_t init_lock; + enum init_state state; + pthread_cond_t cond; + pthread_mutex_t lock; }; enum irm_state { @@ -107,6 +107,7 @@ struct { struct list_head registry; /* registered names known */ struct list_head ipcps; /* list of ipcps in system */ + size_t n_ipcps; /* number of ipcps */ struct list_head proc_table; /* processes */ struct list_head prog_table; /* programs known */ @@ -197,47 +198,116 @@ static struct irm_flow * get_irm_flow_n(pid_t n_pid) return NULL; } -static struct ipcp_entry * ipcp_entry_create(void) +static struct ipcp_entry * ipcp_entry_create(const char * name, + enum ipcp_type type) { - struct ipcp_entry * e = malloc(sizeof(*e)); + struct ipcp_entry * e; + pthread_condattr_t cattr; + + e = malloc(sizeof(*e)); if (e == NULL) - return NULL; + goto fail_malloc; + + e->layer = NULL; + e->type = type; + e->state = IPCP_BOOT; + e->name = strdup(name); + if (e->name == NULL) + goto fail_name; + + if (pthread_condattr_init(&cattr)) + goto fail_cattr; +#ifndef __APPLE__ + pthread_condattr_setclock(&cattr, PTHREAD_COND_CLOCK); +#endif + if (pthread_cond_init(&e->cond, &cattr)) + goto fail_cond; + + if (pthread_mutex_init(&e->lock, NULL)) + goto fail_mutex; - e->name = NULL; - e->layer_name = NULL; list_head_init(&e->next); + pthread_condattr_destroy(&cattr); + return e; + + fail_mutex: + pthread_cond_destroy(&e->cond); + fail_cond: + pthread_condattr_destroy(&cattr); + fail_cattr: + free(e->name); + fail_name: + free(e); + fail_malloc: + return NULL; } static void ipcp_entry_destroy(struct ipcp_entry * e) { assert(e); - pthread_mutex_lock(&e->init_lock); + pthread_mutex_lock(&e->lock); - while (e->init_state == IPCP_BOOT) - pthread_cond_wait(&e->init_cond, &e->init_lock); + while (e->state == IPCP_BOOT) + pthread_cond_wait(&e->cond, &e->lock); - pthread_mutex_unlock(&e->init_lock); + pthread_mutex_unlock(&e->lock); - if (e->name != NULL) - free(e->name); + free(e->name); + free(e->layer); + free(e); +} - if (e->layer_name != NULL) - free(e->layer_name); +static void ipcp_entry_set_state(struct ipcp_entry * e, + enum init_state state) +{ + pthread_mutex_lock(&e->lock); + e->state = state; + pthread_cond_broadcast(&e->cond); + pthread_mutex_unlock(&e->lock); +} - free(e); +static int ipcp_entry_wait_boot(struct ipcp_entry * e) +{ + int ret = 0; + struct timespec dl; + struct timespec to = {SOCKET_TIMEOUT / 1000, + (SOCKET_TIMEOUT % 1000) * MILLION}; + + clock_gettime(PTHREAD_COND_CLOCK, &dl); + ts_add(&dl, &to, &dl); + + pthread_mutex_lock(&e->lock); + + while (e->state == IPCP_BOOT && ret != ETIMEDOUT) + ret = pthread_cond_timedwait(&e->cond, &e->lock, &dl); + + if (ret == ETIMEDOUT) { + kill(e->pid, SIGTERM); + e->state = IPCP_NULL; + pthread_cond_signal(&e->cond); + } + + if (e->state != IPCP_LIVE) { + pthread_mutex_unlock(&e->lock); + return -1; + } + + pthread_mutex_unlock(&e->lock); + + return 0; } static struct ipcp_entry * get_ipcp_entry_by_pid(pid_t pid) { - struct list_head * p = NULL; + struct list_head * p; list_for_each(p, &irmd.ipcps) { struct ipcp_entry * e = list_entry(p, struct ipcp_entry, next); - if (pid == e->pid) + if (e->pid == pid) return e; } @@ -246,7 +316,7 @@ static struct ipcp_entry * get_ipcp_entry_by_pid(pid_t pid) static struct ipcp_entry * get_ipcp_entry_by_name(const char * name) { - struct list_head * p = NULL; + struct list_head * p; list_for_each(p, &irmd.ipcps) { struct ipcp_entry * e = list_entry(p, struct ipcp_entry, next); @@ -264,15 +334,18 @@ static struct ipcp_entry * get_ipcp_by_dst_name(const char * name, struct list_head * h; uint8_t * hash; pid_t pid; + size_t len; pthread_rwlock_rdlock(&irmd.reg_lock); list_for_each_safe(p, h, &irmd.ipcps) { struct ipcp_entry * e = list_entry(p, struct ipcp_entry, next); - if (e->layer_name == NULL || e->pid == src) + if (e->layer == NULL || e->pid == src) continue; - hash = malloc(IPCP_HASH_LEN(e)); + len = IPCP_HASH_LEN(e); + + hash = malloc(len); if (hash == NULL) return NULL; @@ -282,7 +355,7 @@ static struct ipcp_entry * get_ipcp_by_dst_name(const char * name, pthread_rwlock_unlock(&irmd.reg_lock); - if (ipcp_query(pid, hash, IPCP_HASH_LEN(e)) == 0) { + if (ipcp_query(pid, hash, len) == 0) { free(hash); return e; } @@ -297,134 +370,89 @@ static struct ipcp_entry * get_ipcp_by_dst_name(const char * name, return NULL; } -static pid_t create_ipcp(char * name, - enum ipcp_type ipcp_type) +static pid_t create_ipcp(const char * name, + enum ipcp_type type) { - struct pid_el * ppid = NULL; - struct ipcp_entry * tmp = NULL; - struct list_head * p = NULL; - struct ipcp_entry * entry = NULL; - int ret = 0; - pthread_condattr_t cattr; - struct timespec dl; - struct timespec to = {SOCKET_TIMEOUT / 1000, - (SOCKET_TIMEOUT % 1000) * MILLION}; - pid_t ipcp_pid; - - ppid = malloc(sizeof(*ppid)); - if (ppid == NULL) - return -ENOMEM; + struct pid_el * ppid; + struct ipcp_entry * entry; + struct list_head * p; + pid_t pid; - pthread_rwlock_wrlock(&irmd.reg_lock); + pthread_rwlock_rdlock(&irmd.reg_lock); entry = get_ipcp_entry_by_name(name); if (entry != NULL) { pthread_rwlock_unlock(&irmd.reg_lock); - free(ppid); log_err("IPCP by that name already exists."); - return -1; - } - - ppid->pid = ipcp_create(name, ipcp_type); - if (ppid->pid == -1) { - pthread_rwlock_unlock(&irmd.reg_lock); - free(ppid); - log_err("Failed to create IPCP."); - return -1; + return -EPERM; } - tmp = ipcp_entry_create(); - if (tmp == NULL) { - pthread_rwlock_unlock(&irmd.reg_lock); - free(ppid); - return -1; - } + pthread_rwlock_unlock(&irmd.reg_lock); - list_head_init(&tmp->next); + ppid = malloc(sizeof(*ppid)); + if (ppid == NULL) + goto fail_ppid; - tmp->name = strdup(name); - if (tmp->name == NULL) { - ipcp_entry_destroy(tmp); - pthread_rwlock_unlock(&irmd.reg_lock); - free(ppid); - return -1; + entry = ipcp_entry_create(name, type); + if (entry == NULL) { + log_err("Failed to create IPCP entry."); + goto fail_ipcp_entry; } - pthread_condattr_init(&cattr); -#ifndef __APPLE__ - pthread_condattr_setclock(&cattr, PTHREAD_COND_CLOCK); -#endif - - pthread_cond_init(&tmp->init_cond, &cattr); - - pthread_condattr_destroy(&cattr); + pid = ipcp_create(name, type); + if (pid == -1) { + log_err("Failed to create IPCP."); + goto fail_ipcp; + } - pthread_mutex_init(&tmp->init_lock, NULL); + entry->pid = pid; - tmp->pid = ppid->pid; - tmp->layer_name = NULL; - tmp->type = ipcp_type; - tmp->init_state = IPCP_BOOT; - tmp->dir_hash_algo = -1; - ipcp_pid = tmp->pid; + pthread_rwlock_wrlock(&irmd.reg_lock); list_for_each(p, &irmd.ipcps) { - struct ipcp_entry * e = list_entry(p, struct ipcp_entry, next); - if (e->type > ipcp_type) + if (list_entry(p, struct ipcp_entry, next)->type > type) break; } - list_add_tail(&tmp->next, p); + list_add_tail(&entry->next, p); + ++irmd.n_ipcps; + ppid->pid = entry->pid; list_add(&ppid->next, &irmd.spawned_pids); pthread_rwlock_unlock(&irmd.reg_lock); - pthread_mutex_lock(&tmp->init_lock); - - clock_gettime(PTHREAD_COND_CLOCK, &dl); - ts_add(&dl, &to, &dl); - - while (tmp->init_state == IPCP_BOOT && ret != -ETIMEDOUT) - ret = -pthread_cond_timedwait(&tmp->init_cond, - &tmp->init_lock, - &dl); - - if (ret == -ETIMEDOUT) { - kill(tmp->pid, SIGKILL); - tmp->init_state = IPCP_NULL; - pthread_cond_signal(&tmp->init_cond); - pthread_mutex_unlock(&tmp->init_lock); - log_err("IPCP %d failed to respond.", ipcp_pid); + /* IRMd maintenance will clean up if booting fails. */ + if (ipcp_entry_wait_boot(entry)) { + log_err("IPCP %d failed to boot.", pid); return -1; } - pthread_mutex_unlock(&tmp->init_lock); + log_info("Created IPCP %d.", pid); - log_info("Created IPCP %d.", ipcp_pid); + return pid; - return ipcp_pid; + ipcp_destroy(pid); + fail_ipcp: + ipcp_entry_destroy(entry); + fail_ipcp_entry: + free(ppid); + fail_ppid: + return -1; } static int create_ipcp_r(pid_t pid, int result) { - struct list_head * pos = NULL; - - if (result != 0) - return result; + struct list_head * p; pthread_rwlock_rdlock(&irmd.reg_lock); - list_for_each(pos, &irmd.ipcps) { - struct ipcp_entry * e = - list_entry(pos, struct ipcp_entry, next); - + list_for_each(p, &irmd.ipcps) { + struct ipcp_entry * e = list_entry(p, struct ipcp_entry, next); if (e->pid == pid) { - pthread_mutex_lock(&e->init_lock); - e->init_state = IPCP_LIVE; - pthread_cond_broadcast(&e->init_cond); - pthread_mutex_unlock(&e->init_lock); + ipcp_entry_set_state(e, result ? IPCP_NULL : IPCP_LIVE); + break; } } @@ -435,12 +463,12 @@ static int create_ipcp_r(pid_t pid, static void clear_spawned_process(pid_t pid) { - struct list_head * pos = NULL; - struct list_head * n = NULL; + struct list_head * p; + struct list_head * h; - list_for_each_safe(pos, n, &(irmd.spawned_pids)) { - struct pid_el * a = list_entry(pos, struct pid_el, next); - if (pid == a->pid) { + list_for_each_safe(p, h, &(irmd.spawned_pids)) { + struct pid_el * a = list_entry(p, struct pid_el, next); + if (a->pid == pid) { list_del(&a->next); free(a); } @@ -449,22 +477,20 @@ static void clear_spawned_process(pid_t pid) static int destroy_ipcp(pid_t pid) { - struct list_head * pos = NULL; - struct list_head * n = NULL; + struct list_head * p; + struct list_head * h; pthread_rwlock_wrlock(&irmd.reg_lock); - list_for_each_safe(pos, n, &(irmd.ipcps)) { - struct ipcp_entry * tmp = - list_entry(pos, struct ipcp_entry, next); - - if (pid == tmp->pid) { + list_for_each_safe(p, h, &irmd.ipcps) { + struct ipcp_entry * e = list_entry(p, struct ipcp_entry, next); + if (e->pid == pid) { clear_spawned_process(pid); if (ipcp_destroy(pid)) log_err("Could not destroy IPCP."); - list_del(&tmp->next); - ipcp_entry_destroy(tmp); - + list_del(&e->next); + ipcp_entry_destroy(e); + --irmd.n_ipcps; log_info("Destroyed IPCP %d.", pid); } } @@ -477,7 +503,7 @@ static int destroy_ipcp(pid_t pid) static int bootstrap_ipcp(pid_t pid, ipcp_config_msg_t * conf) { - struct ipcp_entry * entry = NULL; + struct ipcp_entry * entry; struct layer_info info; pthread_rwlock_wrlock(&irmd.reg_lock); @@ -501,8 +527,8 @@ static int bootstrap_ipcp(pid_t pid, return -1; } - entry->layer_name = strdup(info.layer_name); - if (entry->layer_name == NULL) { + entry->layer = strdup(info.layer_name); + if (entry->layer == NULL) { pthread_rwlock_unlock(&irmd.reg_lock); log_warn("Failed to set name of layer."); return -ENOMEM; @@ -519,7 +545,7 @@ static int bootstrap_ipcp(pid_t pid, } static int enroll_ipcp(pid_t pid, - char * dst_name) + char * dst) { struct ipcp_entry * entry = NULL; struct layer_info info; @@ -533,7 +559,7 @@ static int enroll_ipcp(pid_t pid, return -1; } - if (entry->layer_name != NULL) { + if (entry->layer != NULL) { pthread_rwlock_unlock(&irmd.reg_lock); log_err("IPCP in wrong state"); return -1; @@ -541,7 +567,7 @@ static int enroll_ipcp(pid_t pid, pthread_rwlock_unlock(&irmd.reg_lock); - if (ipcp_enroll(pid, dst_name, &info) < 0) { + if (ipcp_enroll(pid, dst, &info) < 0) { log_err("Could not enroll IPCP %d.", pid); return -1; } @@ -555,8 +581,8 @@ static int enroll_ipcp(pid_t pid, return -1; } - entry->layer_name = strdup(info.layer_name); - if (entry->layer_name == NULL) { + entry->layer = strdup(info.layer_name); + if (entry->layer == NULL) { pthread_rwlock_unlock(&irmd.reg_lock); log_err("Failed to strdup layer_name."); return -ENOMEM; @@ -648,13 +674,13 @@ static int bind_program(char * prog, int argc, char ** argv) { - char * progs; - char * progn; - char ** argv_dup = NULL; - int i; - char * name_dup = NULL; - struct prog_entry * e = NULL; - struct reg_entry * re = NULL; + char * progs; + char * progn; + char ** argv_dup = NULL; + int i; + char * name_dup = NULL; + struct prog_entry * e = NULL; + struct reg_entry * re = NULL; if (prog == NULL || name == NULL) return -EINVAL; @@ -662,7 +688,6 @@ static int bind_program(char * prog, pthread_rwlock_wrlock(&irmd.reg_lock); e = prog_table_get(&irmd.prog_table, path_strip(prog)); - if (e == NULL) { progs = strdup(path_strip(prog)); if (progs == NULL) { @@ -704,9 +729,7 @@ static int bind_program(char * prog, argvfree(argv_dup); return -ENOMEM; } - prog_table_add(&irmd.prog_table, e); - } name_dup = strdup(name); @@ -835,68 +858,78 @@ static int unbind_process(pid_t pid, return 0; } -static ssize_t list_ipcps(char * name, - pid_t ** pids) +static ssize_t list_ipcps(ipcp_info_msg_t *** ipcps, + size_t * n_ipcps) { - struct list_head * pos = NULL; - size_t count = 0; - int i = 0; + struct list_head * p; + int i = 0; pthread_rwlock_rdlock(&irmd.reg_lock); - list_for_each(pos, &irmd.ipcps) { - struct ipcp_entry * tmp = - list_entry(pos, struct ipcp_entry, next); - if (wildcard_match(name, tmp->name) == 0) - count++; - } + *n_ipcps = irmd.n_ipcps; - if (count == 0) { + if (*n_ipcps == 0) { pthread_rwlock_unlock(&irmd.reg_lock); return 0; } - *pids = malloc(count * sizeof(**pids)); - if (*pids == NULL) { + *ipcps = malloc(irmd.n_ipcps * sizeof(**ipcps)); + if (*ipcps == NULL) { pthread_rwlock_unlock(&irmd.reg_lock); + *n_ipcps = 0; return -1; } - list_for_each(pos, &irmd.ipcps) { - struct ipcp_entry * tmp = - list_entry(pos, struct ipcp_entry, next); - if (wildcard_match(name, tmp->name) == 0) - (*pids)[i++] = tmp->pid; - } + list_for_each(p, &irmd.ipcps) { + struct ipcp_entry * e = list_entry(p, struct ipcp_entry, next); + (*ipcps)[i] = malloc(sizeof(***ipcps)); + if ((*ipcps)[i] == NULL) + goto fail_malloc; + + ipcp_info_msg__init((*ipcps)[i]); + (*ipcps)[i]->name = strdup(e->name); + if ((*ipcps)[i]->name == NULL) + goto fail_mem; + + (*ipcps)[i]->layer = strdup( + e->layer != NULL ? e->layer : "Not enrolled"); + if ((*ipcps)[i]->layer == NULL) + goto fail_mem; + + (*ipcps)[i]->pid = e->pid; + (*ipcps)[i++]->type = e->type; + } pthread_rwlock_unlock(&irmd.reg_lock); - return count; + return 0; + + fail_mem: + while (i > 0) { + free((*ipcps)[i]->layer); + free((*ipcps)[i]->name); + free(*ipcps[--i]); + } + free(*ipcps); + *n_ipcps = 0; + return -ENOMEM; + + fail_malloc: + while (i > 0) + free(*ipcps[--i]); + free(*ipcps); + *n_ipcps = 0; + return -ENOMEM; } -static int name_reg(const char * name, - char ** layers, - size_t len) +static int irm_update_name(const char * name) { - size_t i; - int ret = 0; - struct list_head * p = NULL; - - assert(name); - assert(len); - assert(layers); - assert(layers[0]); + struct list_head * p; pthread_rwlock_wrlock(&irmd.reg_lock); - if (list_is_empty(&irmd.ipcps)) { - pthread_rwlock_unlock(&irmd.reg_lock); - return -1; - } - if (!registry_has_name(&irmd.registry, name)) { - struct reg_entry * re = - registry_add_name(&irmd.registry, name); + struct reg_entry * re = registry_add_name(&irmd.registry, name); if (re == NULL) { log_err("Failed creating registry entry for %s.", name); pthread_rwlock_unlock(&irmd.reg_lock); @@ -906,11 +939,11 @@ static int name_reg(const char * name, /* check the tables for client programs */ list_for_each(p, &irmd.proc_table) { struct list_head * q; - struct proc_entry * e = - list_entry(p, struct proc_entry, next); + struct proc_entry * e; + e = list_entry(p, struct proc_entry, next); list_for_each(q, &e->names) { - struct str_el * s = - list_entry(q, struct str_el, next); + struct str_el * s; + s = list_entry(q, struct str_el, next); if (!strcmp(s->str, name)) reg_entry_add_pid(re, e->pid); } @@ -918,145 +951,145 @@ static int name_reg(const char * name, list_for_each(p, &irmd.prog_table) { struct list_head * q; - struct prog_entry * e = - list_entry(p, struct prog_entry, next); + struct prog_entry * e; + e = list_entry(p, struct prog_entry, next); list_for_each(q, &e->names) { - struct str_el * s = - list_entry(q, struct str_el, next); + struct str_el * s; + s = list_entry(q, struct str_el, next); if (!strcmp(s->str, name)) reg_entry_add_prog(re, e); } } } - list_for_each(p, &irmd.ipcps) { - struct ipcp_entry * e = list_entry(p, struct ipcp_entry, next); - if (e->layer_name == NULL) - continue; + pthread_rwlock_unlock(&irmd.reg_lock); - for (i = 0; i < len; ++i) { - uint8_t * hash; - pid_t pid; - size_t len; + return 0; +} - if (wildcard_match(layers[i], e->layer_name)) - continue; +static int name_reg(pid_t pid, + const char * name) +{ + size_t len; + struct ipcp_entry * ipcp; + uint8_t * hash; + int err; - hash = malloc(IPCP_HASH_LEN(e)); - if (hash == NULL) - break; + assert(name); - str_hash(e->dir_hash_algo, hash, name); + pthread_rwlock_wrlock(&irmd.reg_lock); - pid = e->pid; - len = IPCP_HASH_LEN(e); + ipcp = get_ipcp_entry_by_pid(pid); + if (ipcp == NULL) { + err = -EIPCP; + goto fail; + } - pthread_rwlock_unlock(&irmd.reg_lock); + if (ipcp->layer == NULL) { + err = -EPERM; + goto fail; + } - if (ipcp_reg(pid, hash, len)) { - log_err("Could not register " HASH_FMT - " with IPCP %d.", - HASH_VAL(hash), pid); - pthread_rwlock_wrlock(&irmd.reg_lock); - free(hash); - break; - } + len = IPCP_HASH_LEN(ipcp); - pthread_rwlock_wrlock(&irmd.reg_lock); + hash = malloc(len); + if (hash == NULL) { + err = -ENOMEM; + goto fail; + } - log_info("Registered %s in %s as " HASH_FMT ".", - name, e->layer_name, HASH_VAL(hash)); - ++ret; + str_hash(ipcp->dir_hash_algo, hash, name); + pthread_rwlock_unlock(&irmd.reg_lock); - free(hash); - } + if (ipcp_reg(pid, hash, len)) { + log_err("Could not register " HASH_FMT " with IPCP %d.", + HASH_VAL(hash), pid); + free(hash); + return -1; } - pthread_rwlock_unlock(&irmd.reg_lock); + irm_update_name(name); - return (ret > 0 ? 0 : -1); + log_info("Registered %s with IPCP %d as " HASH_FMT ".", + name, pid, HASH_VAL(hash)); + + free(hash); + + return 0; + +fail: + pthread_rwlock_unlock(&irmd.reg_lock); + return err; } -static int name_unreg(const char * name, - char ** layers, - size_t len) +static int name_unreg(pid_t pid, + const char * name) { - size_t i; - int ret = 0; - struct list_head * pos = NULL; + struct ipcp_entry * ipcp; + int err; + uint8_t * hash; + size_t len; assert(name); - assert(len); - assert(layers); - assert(layers[0]); pthread_rwlock_wrlock(&irmd.reg_lock); - list_for_each(pos, &irmd.ipcps) { - struct ipcp_entry * e = - list_entry(pos, struct ipcp_entry, next); - - if (e->layer_name == NULL) - continue; - - for (i = 0; i < len; ++i) { - uint8_t * hash; - pid_t pid; - size_t len; + ipcp = get_ipcp_entry_by_pid(pid); + if (ipcp == NULL) { + err = -EIPCP; + goto fail; + } - if (wildcard_match(layers[i], e->layer_name)) - continue; + if (ipcp->layer == NULL) { + err = -EPERM; + goto fail; + } - hash = malloc(IPCP_HASH_LEN(e)); - if (hash == NULL) - break; + len = IPCP_HASH_LEN(ipcp); - str_hash(e->dir_hash_algo, hash, name); + hash = malloc(len); + if (hash == NULL) { + err = -ENOMEM; + goto fail; + } - pid = e->pid; - len = IPCP_HASH_LEN(e); + str_hash(ipcp->dir_hash_algo, hash, name); - pthread_rwlock_unlock(&irmd.reg_lock); + pthread_rwlock_unlock(&irmd.reg_lock); - if (ipcp_unreg(pid, hash, len)) { - log_err("Could not unregister %s with IPCP %d.", - name, pid); - pthread_rwlock_wrlock(&irmd.reg_lock); - free(hash); - break; - } + if (ipcp_unreg(pid, hash, len)) { + log_err("Could not unregister %s with IPCP %d.", name, pid); + free(hash); + return -1; + } - pthread_rwlock_wrlock(&irmd.reg_lock); + log_info("Unregistered %s from %d.", name, pid); - log_info("Unregistered %s from %s.", - name, e->layer_name); - ++ret; + free(hash); - free(hash); - } - } + return 0; + fail: pthread_rwlock_unlock(&irmd.reg_lock); - - return (ret > 0 ? 0 : -1); + return err; } static int proc_announce(pid_t pid, char * prog) { - struct proc_entry * e = NULL; - struct prog_entry * a = NULL; - char * prog_dup; - if (prog == NULL) - return -EINVAL; + struct proc_entry * e; + struct prog_entry * a; + char * prog_dup; + + assert(prog); prog_dup = strdup(prog); - if (prog_dup == NULL) { + if (prog_dup == NULL) return -ENOMEM; - } e = proc_entry_create(pid, prog_dup); if (e == NULL) { + free(prog_dup); return -ENOMEM; } @@ -1065,7 +1098,6 @@ static int proc_announce(pid_t pid, proc_table_add(&irmd.proc_table, e); /* Copy listen names from program if it exists. */ - a = prog_table_get(&irmd.prog_table, e->prog); if (a != NULL) { struct list_head * p; @@ -1876,17 +1908,24 @@ static void * mainloop(void * o) (void) o; while (true) { - irm_msg_t ret_msg = IRM_MSG__INIT; + irm_msg_t * ret_msg; struct irm_flow * e = NULL; - pid_t * pids = NULL; struct timespec * timeo = NULL; struct timespec ts = {0, 0}; struct cmd * cmd; - ret_msg.code = IRM_MSG_CODE__IRM_REPLY; + ret_msg = malloc(sizeof(*ret_msg)); + if (ret_msg == NULL) + return (void *) -1; + + irm_msg__init(ret_msg); + + ret_msg->code = IRM_MSG_CODE__IRM_REPLY; + pthread_mutex_lock(&irmd.cmd_lock); + pthread_cleanup_push(free_msg, ret_msg); pthread_cleanup_push((void *)(void *) pthread_mutex_unlock, &irmd.cmd_lock); @@ -1897,6 +1936,7 @@ static void * mainloop(void * o) list_del(&cmd->next); pthread_cleanup_pop(true); + pthread_cleanup_pop(false); msg = irm_msg__unpack(NULL, cmd->len, cmd->cbuf); sfd = cmd->fd; @@ -1905,6 +1945,7 @@ static void * mainloop(void * o) if (msg == NULL) { close(sfd); + irm_msg__free_unpacked(ret_msg, NULL); continue; } @@ -1920,151 +1961,145 @@ static void * mainloop(void * o) pthread_cleanup_push(close_ptr, &sfd); pthread_cleanup_push(free_msg, msg); + pthread_cleanup_push(free_msg, ret_msg); switch (msg->code) { case IRM_MSG_CODE__IRM_CREATE_IPCP: - ret_msg.has_result = true; - ret_msg.result = create_ipcp(msg->dst_name, - msg->ipcp_type); + ret_msg->has_result = true; + ret_msg->result = create_ipcp(msg->name, + msg->ipcp_type); break; case IRM_MSG_CODE__IPCP_CREATE_R: - ret_msg.has_result = true; - ret_msg.result = create_ipcp_r(msg->pid, msg->result); + ret_msg->has_result = true; + ret_msg->result = create_ipcp_r(msg->pid, msg->result); break; case IRM_MSG_CODE__IRM_DESTROY_IPCP: - ret_msg.has_result = true; - ret_msg.result = destroy_ipcp(msg->pid); + ret_msg->has_result = true; + ret_msg->result = destroy_ipcp(msg->pid); break; case IRM_MSG_CODE__IRM_BOOTSTRAP_IPCP: - ret_msg.has_result = true; - ret_msg.result = bootstrap_ipcp(msg->pid, msg->conf); + ret_msg->has_result = true; + ret_msg->result = bootstrap_ipcp(msg->pid, msg->conf); break; case IRM_MSG_CODE__IRM_ENROLL_IPCP: - ret_msg.has_result = true; - ret_msg.result = enroll_ipcp(msg->pid, - msg->layer_name[0]); + ret_msg->has_result = true; + ret_msg->result = enroll_ipcp(msg->pid, msg->dst); break; case IRM_MSG_CODE__IRM_CONNECT_IPCP: - ret_msg.has_result = true; - ret_msg.result = connect_ipcp(msg->pid, - msg->dst_name, - msg->comp_name); + ret_msg->has_result = true; + ret_msg->result = connect_ipcp(msg->pid, + msg->dst, + msg->comp); break; case IRM_MSG_CODE__IRM_DISCONNECT_IPCP: - ret_msg.has_result = true; - ret_msg.result = disconnect_ipcp(msg->pid, - msg->dst_name, - msg->comp_name); + ret_msg->has_result = true; + ret_msg->result = disconnect_ipcp(msg->pid, + msg->dst, + msg->comp); break; case IRM_MSG_CODE__IRM_BIND_PROGRAM: - ret_msg.has_result = true; - ret_msg.result = bind_program(msg->prog_name, - msg->dst_name, - msg->opts, - msg->n_args, - msg->args); + ret_msg->has_result = true; + ret_msg->result = bind_program(msg->prog, + msg->name, + msg->opts, + msg->n_args, + msg->args); break; case IRM_MSG_CODE__IRM_UNBIND_PROGRAM: - ret_msg.has_result = true; - ret_msg.result = unbind_program(msg->prog_name, - msg->dst_name); + ret_msg->has_result = true; + ret_msg->result = unbind_program(msg->prog, msg->name); break; case IRM_MSG_CODE__IRM_PROC_ANNOUNCE: - ret_msg.has_result = true; - ret_msg.result = proc_announce(msg->pid, - msg->prog_name); + ret_msg->has_result = true; + ret_msg->result = proc_announce(msg->pid, msg->prog); break; case IRM_MSG_CODE__IRM_BIND_PROCESS: - ret_msg.has_result = true; - ret_msg.result = bind_process(msg->pid, msg->dst_name); + ret_msg->has_result = true; + ret_msg->result = bind_process(msg->pid, msg->name); break; case IRM_MSG_CODE__IRM_UNBIND_PROCESS: - ret_msg.has_result = true; - ret_msg.result = unbind_process(msg->pid, - msg->dst_name); + ret_msg->has_result = true; + ret_msg->result = unbind_process(msg->pid, msg->name); break; case IRM_MSG_CODE__IRM_LIST_IPCPS: - ret_msg.has_result = true; - ret_msg.n_pids = list_ipcps(msg->dst_name, &pids); - ret_msg.pids = pids; + ret_msg->has_result = true; + ret_msg->result = list_ipcps(&ret_msg->ipcps, + &ret_msg->n_ipcps); break; case IRM_MSG_CODE__IRM_REG: - ret_msg.has_result = true; - ret_msg.result = name_reg(msg->dst_name, - msg->layer_name, - msg->n_layer_name); + ret_msg->has_result = true; + ret_msg->result = name_reg(msg->pid, msg->name); break; case IRM_MSG_CODE__IRM_UNREG: - ret_msg.has_result = true; - ret_msg.result = name_unreg(msg->dst_name, - msg->layer_name, - msg->n_layer_name); + ret_msg->has_result = true; + ret_msg->result = name_unreg(msg->pid, msg->name); break; case IRM_MSG_CODE__IRM_FLOW_ACCEPT: - ret_msg.has_result = true; - ret_msg.result = flow_accept(msg->pid, timeo, &e); - if (ret_msg.result == 0) { - ret_msg.has_port_id = true; - ret_msg.port_id = e->port_id; - ret_msg.has_pid = true; - ret_msg.pid = e->n_1_pid; - ret_msg.has_qoscube = true; - ret_msg.qoscube = e->qc; + ret_msg->has_result = true; + ret_msg->result = flow_accept(msg->pid, timeo, &e); + if (ret_msg->result == 0) { + ret_msg->has_port_id = true; + ret_msg->port_id = e->port_id; + ret_msg->has_pid = true; + ret_msg->pid = e->n_1_pid; + ret_msg->has_qoscube = true; + ret_msg->qoscube = e->qc; } break; case IRM_MSG_CODE__IRM_FLOW_ALLOC: - ret_msg.has_result = true; - ret_msg.result = flow_alloc(msg->pid, msg->dst_name, - msg->qoscube, timeo, &e); - if (ret_msg.result == 0) { - ret_msg.has_port_id = true; - ret_msg.port_id = e->port_id; - ret_msg.has_pid = true; - ret_msg.pid = e->n_1_pid; + ret_msg->has_result = true; + ret_msg->result = flow_alloc(msg->pid, msg->dst, + msg->qoscube, timeo, &e); + if (ret_msg->result == 0) { + ret_msg->has_port_id = true; + ret_msg->port_id = e->port_id; + ret_msg->has_pid = true; + ret_msg->pid = e->n_1_pid; } break; case IRM_MSG_CODE__IRM_FLOW_DEALLOC: - ret_msg.has_result = true; - ret_msg.result = flow_dealloc(msg->pid, msg->port_id); + ret_msg->has_result = true; + ret_msg->result = flow_dealloc(msg->pid, msg->port_id); break; case IRM_MSG_CODE__IPCP_FLOW_REQ_ARR: e = flow_req_arr(msg->pid, msg->hash.data, msg->qoscube); - ret_msg.has_result = true; + ret_msg->has_result = true; if (e == NULL) { - ret_msg.result = -1; + ret_msg->result = -1; break; } - ret_msg.has_port_id = true; - ret_msg.port_id = e->port_id; - ret_msg.has_pid = true; - ret_msg.pid = e->n_pid; + ret_msg->has_port_id = true; + ret_msg->port_id = e->port_id; + ret_msg->has_pid = true; + ret_msg->pid = e->n_pid; break; case IRM_MSG_CODE__IPCP_FLOW_ALLOC_REPLY: - ret_msg.has_result = true; - ret_msg.result = flow_alloc_reply(msg->port_id, - msg->response); + ret_msg->has_result = true; + ret_msg->result = flow_alloc_reply(msg->port_id, + msg->response); break; default: log_err("Don't know that message code."); break; } + pthread_cleanup_pop(false); pthread_cleanup_pop(true); pthread_cleanup_pop(false); - if (ret_msg.result == -EPIPE || !ret_msg.has_result) { + if (ret_msg->result == -EPIPE || !ret_msg->has_result) { + irm_msg__free_unpacked(ret_msg, NULL); close(sfd); tpm_inc(irmd.tpm); continue; } - buffer.len = irm_msg__get_packed_size(&ret_msg); + buffer.len = irm_msg__get_packed_size(ret_msg); if (buffer.len == 0) { log_err("Failed to calculate length of reply message."); - if (pids != NULL) - free(pids); + irm_msg__free_unpacked(ret_msg, NULL); close(sfd); tpm_inc(irmd.tpm); continue; @@ -2072,22 +2107,20 @@ static void * mainloop(void * o) buffer.data = malloc(buffer.len); if (buffer.data == NULL) { - if (pids != NULL) - free(pids); + irm_msg__free_unpacked(ret_msg, NULL); close(sfd); tpm_inc(irmd.tpm); continue; } - irm_msg__pack(&ret_msg, buffer.data); + irm_msg__pack(ret_msg, buffer.data); - if (pids != NULL) - free(pids); + irm_msg__free_unpacked(ret_msg, NULL); pthread_cleanup_push(close_ptr, &sfd); if (write(sfd, buffer.data, buffer.len) == -1) - if (ret_msg.result != -EIRMD) + if (ret_msg->result != -EIRMD) log_warn("Failed to send reply message."); free(buffer.data); diff --git a/src/irmd/proc_table.c b/src/irmd/proc_table.c index beda2f62..e8d08447 100644 --- a/src/irmd/proc_table.c +++ b/src/irmd/proc_table.c @@ -166,7 +166,7 @@ void proc_entry_del_name(struct proc_entry * e, list_for_each_safe(p, h, &e->names) { struct str_el * s = list_entry(p, struct str_el, next); - if (!wildcard_match(name, s->str)) { + if (!strcmp(name, s->str)) { list_del(&s->next); if (s->str != NULL) free(s->str); diff --git a/src/irmd/prog_table.c b/src/irmd/prog_table.c index 563e7e10..bd69e156 100644 --- a/src/irmd/prog_table.c +++ b/src/irmd/prog_table.c @@ -115,7 +115,7 @@ void prog_entry_del_name(struct prog_entry * e, list_for_each_safe(p, h, &e->names) { struct str_el * s = list_entry(p, struct str_el, next); - if (!wildcard_match(name, s->str)) { + if (!strcmp(name, s->str)) { list_del(&s->next); if (s->str != NULL) free(s->str); @@ -146,7 +146,7 @@ void prog_table_del(struct list_head * prog_table, list_for_each_safe(p, h, prog_table) { struct prog_entry * e = list_entry(p, struct prog_entry, next); - if (!wildcard_match(prog, e->prog)) { + if (!strcmp(prog, e->prog)) { list_del(&e->next); prog_entry_destroy(e); } diff --git a/src/irmd/registry.c b/src/irmd/registry.c index 6da36055..145a7452 100644 --- a/src/irmd/registry.c +++ b/src/irmd/registry.c @@ -44,7 +44,9 @@ static struct reg_entry * reg_entry_create(void) { - struct reg_entry * e = malloc(sizeof(*e)); + struct reg_entry * e; + + e = malloc(sizeof(*e)); if (e == NULL) return NULL; @@ -59,8 +61,8 @@ static int reg_entry_init(struct reg_entry * e, { pthread_condattr_t cattr; - if (e == NULL || name == NULL) - return -1; + assert(e); + assert(name); list_head_init(&e->next); list_head_init(&e->reg_progs); @@ -69,20 +71,29 @@ static int reg_entry_init(struct reg_entry * e, e->name = name; if (pthread_condattr_init(&cattr)) - return -1; + goto fail_cattr; #ifndef __APPLE__ pthread_condattr_setclock(&cattr, PTHREAD_COND_CLOCK); #endif if (pthread_cond_init(&e->state_cond, &cattr)) - return -1; + goto fail_cond; if (pthread_mutex_init(&e->state_lock, NULL)) - return -1; + goto fail_mutex; + + pthread_condattr_destroy(&cattr); e->state = REG_NAME_IDLE; return 0; + + fail_mutex: + pthread_cond_destroy(&e->state_cond); + fail_cond: + pthread_condattr_destroy(&cattr); + fail_cattr: + return -1; } static void cancel_reg_entry_destroy(void * o) @@ -199,12 +210,12 @@ int reg_entry_add_prog(struct reg_entry * e, void reg_entry_del_prog(struct reg_entry * e, const char * prog) { - struct list_head * p = NULL; - struct list_head * h = NULL; + struct list_head * p; + struct list_head * h; list_for_each_safe(p, h, &e->reg_progs) { struct str_el * e = list_entry(p, struct str_el, next); - if (!wildcard_match(prog, e->str)) { + if (!strcmp(prog, e->str)) { list_del(&e->next); free(e->str); free(e); @@ -470,7 +481,7 @@ struct reg_entry * registry_get_entry(struct list_head * registry, list_for_each(p, registry) { struct reg_entry * e = list_entry(p, struct reg_entry, next); - if (!wildcard_match(name, e->name)) + if (!strcmp(name, e->name)) return e; } diff --git a/src/irmd/registry.h b/src/irmd/registry.h index c570be32..62d90c39 100644 --- a/src/irmd/registry.h +++ b/src/irmd/registry.h @@ -55,8 +55,6 @@ struct reg_entry { struct list_head next; char * name; - /* layers in which this name is registered */ - struct list_head layers; /* Programs that can be instantiated by the irmd */ struct list_head reg_progs; /* Processes that are listening for this name */ diff --git a/src/irmd/utils.c b/src/irmd/utils.c index a13fa485..c2bda581 100644 --- a/src/irmd/utils.c +++ b/src/irmd/utils.c @@ -62,74 +62,3 @@ char ** argvdup(char ** argv) argv_dup[argc] = NULL; return argv_dup; } - -/* - * Copyright (c) 1989, 1993, 1994 - * The Regents of the University of California. All rights reserved. - * - * Wildcard Match code below is derived from software contributed to Berkeley by - * Guido van Rossum. - * - * Copyright (c) 2011 The FreeBSD Foundation - * All rights reserved. - * Portions of this software were developed by David Chisnall - * under sponsorship from the FreeBSD Foundation. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * 4. Neither the name of the University nor the names of its contributors - * may be used to endorse or promote products derived from this software - * without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - * - * wildcard_match is based on the fnmatch function from POSIX.2. - * Implementation based on that one from FreeBSD. - */ - -int wildcard_match(const char * pattern, const char * string) -{ - char c; - - /* For loop? Why not Zoidberg? */ - for (;;) { - switch (c = *pattern++) { - case '\0': - return (*string == '\0' ? 0 : -1); - case '*': - c = *pattern; - - if (c == '\0') - return 0; - - /* General case, use recursion. */ - while ((c = *string) != '\0') { - if (!wildcard_match(pattern, string)) - return 0; - ++string; - } - return -1; - default: - if (c != *string) - return -1; - string++; - break; - } - } -} diff --git a/src/irmd/utils.h b/src/irmd/utils.h index 01a58e38..763e654a 100644 --- a/src/irmd/utils.h +++ b/src/irmd/utils.h @@ -20,11 +20,6 @@ * Foundation, Inc., http://www.fsf.org/about/contact/. */ -/* - * Checks whether the string argument matches the pattern argument, - * which is a wildcard pattern. - */ - #ifndef OUROBOROS_IRMD_UTILS_H #define OUROBOROS_IRMD_UTILS_H @@ -40,9 +35,6 @@ struct pid_el { pid_t pid; }; -int wildcard_match(const char * pattern, - const char * string); - /* functions for copying and destroying arguments list */ char ** argvdup(char ** argv); |