irmd: Fail OAP config load on read errors

load_sec_config_file() treated any fopen() failure as an absent
config and silently disabled encryption.

file_exists() similarly lumped non-ENOENT stat() errors in with
"present".

Signed-off-by: Dimitri Staessens <dimitri@ouroboros.rocks>
Signed-off-by: Sander Vrijders <sander@ouroboros.rocks>

1 files changed, 7 insertions, 1 deletions

diff --git a/src/irmd/oap/io.c b/src/irmd/oap/io.c
index 5c560ea5..7b661435 100644
--- a/src/irmd/oap/io.c
+++ b/src/irmd/oap/io.c
@@ -50,11 +50,17 @@ static bool file_exists(const char * path)
 {
         struct stat s;
 
-        if (stat(path, &s) < 0 && errno == ENOENT) {
+        if (stat(path, &s) == 0)
+                return true;
+
+        if (errno == ENOENT) {
                 log_dbg("File %s does not exist.", path);
                 return false;
         }
 
+        /* Can't stat for another reason; assume present, fail on load */
+        log_warn("Failed to stat %s: %s.", path, strerror(errno));
+
         return true;
 }