build: Comply with -Wextra compiler flag

This reduces the risk for some bugs, for instance due to
signed/unsigned mismatches and unused variables.

3 files changed, 27 insertions, 0 deletions

diff --git a/src/ipcpd/normal/fmgr.c b/src/ipcpd/normal/fmgr.c
index 3da392c5..46c72691 100644
--- a/src/ipcpd/normal/fmgr.c
+++ b/src/ipcpd/normal/fmgr.c
@@ -126,6 +126,8 @@ static void * fmgr_nm1_acceptor(void * o)
         int    fd;
         char * ae_name;
 
+        (void) o;
+
         while (true) {
                 ipcp_wait_state(IPCP_ENROLLED, NULL);
 
@@ -190,6 +192,8 @@ static void * fmgr_np1_sdu_reader(void * o)
         if (fq == NULL)
                 return (void *) 1;
 
+        (void) o;
+
         while (true) {
                 int ret = flow_event_wait(fmgr.np1_set, fq, &timeout);
                 if (ret == -ETIMEDOUT)
@@ -240,6 +244,9 @@ void * fmgr_nm1_sdu_reader(void * o)
         fqueue_t * fq = fqueue_create();
         if (fq == NULL)
                 return (void *) 1;
+
+        (void) o;
+
         while (true) {
                 int ret = flow_event_wait(fmgr.nm1_set, fq, &timeout);
                 if (ret == -ETIMEDOUT)
diff --git a/src/ipcpd/normal/main.c b/src/ipcpd/normal/main.c
index 0339eaf4..32aabdf2 100644
--- a/src/ipcpd/normal/main.c
+++ b/src/ipcpd/normal/main.c
@@ -47,6 +47,8 @@ int irmd_api;
 
 void ipcp_sig_handler(int sig, siginfo_t * info, void * c)
 {
+        (void) c;
+
         switch(sig) {
         case SIGINT:
         case SIGTERM:
diff --git a/src/ipcpd/normal/ribmgr.c b/src/ipcpd/normal/ribmgr.c
index c69a59ce..cd12bcc6 100644
--- a/src/ipcpd/normal/ribmgr.c
+++ b/src/ipcpd/normal/ribmgr.c
@@ -167,6 +167,9 @@ int ribmgr_cdap_reply(struct cdap * instance,
 {
         struct list_head * pos, * n = NULL;
 
+        (void) data;
+        (void) len;
+
         pthread_mutex_lock(&rib.cdap_reqs_lock);
 
         list_for_each_safe(pos, n, &rib.cdap_reqs) {
@@ -202,6 +205,9 @@ int ribmgr_cdap_read(struct cdap * instance,
                      char *        name)
 {
         LOG_MISSING;
+        (void) instance;
+        (void) invoke_id;
+        (void) name;
 
         return -1;
 }
@@ -216,6 +222,8 @@ int ribmgr_cdap_write(struct cdap * instance,
         static_info_msg_t * msg;
         int ret = 0;
 
+        (void) flags;
+
         pthread_rwlock_wrlock(&ipcpi.state_lock);
         if (ipcp_get_state() == IPCP_PENDING_ENROLL &&
             strcmp(name, STATIC_INFO) == 0) {
@@ -272,6 +280,11 @@ int ribmgr_cdap_create(struct cdap * instance,
                        size_t        len)
 {
         LOG_MISSING;
+        (void) instance;
+        (void) invoke_id;
+        (void) name;
+        (void) data;
+        (void) len;
 
         return -1;
 }
@@ -283,6 +296,11 @@ int ribmgr_cdap_delete(struct cdap * instance,
                        size_t        len)
 {
         LOG_MISSING;
+        (void) instance;
+        (void) invoke_id;
+        (void) name;
+        (void) data;
+        (void) len;
 
         return -1;
 }