ipcpd: Avoid false positive use-after-free in DHT

The static analyzer misses the linked list logic. An assertion is
added that indicates that the pointer was changed indirectly by the
previous element.

Signed-off-by: Dimitri Staessens <dimitri.staessens@ugent.be>
Signed-off-by: Sander Vrijders <sander.vrijders@ugent.be>

1 files changed, 1 insertions, 0 deletions

diff --git a/src/ipcpd/normal/dht.c b/src/ipcpd/normal/dht.c
index 917cbc15..069b89d5 100644
--- a/src/ipcpd/normal/dht.c
+++ b/src/ipcpd/normal/dht.c
@@ -863,6 +863,7 @@ static void lookup_update(struct dht *    dht,
                         d = list_last_entry(&lu->contacts,
                                             struct contact, next);
                         list_del(&d->next);
+                        assert(lu->contacts.prv != &d->next);
                         contact_destroy(d);
                         mod = true;
                 }