summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSander Vrijders <sander.vrijders@intec.ugent.be>2016-02-26 16:08:09 +0100
committerSander Vrijders <sander.vrijders@intec.ugent.be>2016-02-26 16:08:09 +0100
commitf02e1f68905a563e1d73a298e0de0e5da8b2eb9f (patch)
treef87e7d2a7e5a9c789a47561b8a715152aac24e43
parent0ab26ce5ae6c80313e55e3251cc0ee180419f696 (diff)
downloadouroboros-f02e1f68905a563e1d73a298e0de0e5da8b2eb9f.tar.gz
ouroboros-f02e1f68905a563e1d73a298e0de0e5da8b2eb9f.zip
lib: Fix two errors
Fixes two errors in the library. The return code of a write to a socket was ignored. A non literal string was passed to sprintf as a literal one.
-rw-r--r--src/lib/irm.c10
-rw-r--r--src/lib/sockets.c2
2 files changed, 8 insertions, 4 deletions
diff --git a/src/lib/irm.c b/src/lib/irm.c
index 2c9b530c..69a98039 100644
--- a/src/lib/irm.c
+++ b/src/lib/irm.c
@@ -46,13 +46,17 @@ int irm_create_ipcp(rina_name_t name,
msg.msgs.create_ipcp.ipcp_type = ipcp_type;
buf = serialize_irm_msg(&msg);
- if (buf == NULL)
+ if (buf == NULL) {
+ close(sockfd);
return -1;
+ }
- write(sockfd, buf->data, buf->size);
+ if (write(sockfd, buf->data, buf->size) == -1) {
+ close(sockfd);
+ return -1;
+ }
close(sockfd);
-
return 0;
}
diff --git a/src/lib/sockets.c b/src/lib/sockets.c
index 095c9e5c..0ebad842 100644
--- a/src/lib/sockets.c
+++ b/src/lib/sockets.c
@@ -45,7 +45,7 @@ int client_socket_open(char * file_name)
}
serv_addr.sun_family = AF_UNIX;
- sprintf(serv_addr.sun_path, file_name);
+ sprintf(serv_addr.sun_path, "%s", file_name);
if (connect(sockfd,
(struct sockaddr *) &serv_addr,