From d5a52f3951fff7ee272bd0d4cd95cd122d07fa64 Mon Sep 17 00:00:00 2001 From: dimitri staessens Date: Fri, 21 Oct 2016 15:28:24 +0200 Subject: build: Comply with -Wextra compiler flag This reduces the risk for some bugs, for instance due to signed/unsigned mismatches and unused variables. --- src/tools/irm/irm.c | 3 +++ src/tools/irm/irm_bind.c | 3 +++ src/tools/irm/irm_ipcp.c | 3 +++ src/tools/irm/irm_unbind.c | 3 +++ src/tools/irm/irm_utils.c | 2 +- 5 files changed, 13 insertions(+), 1 deletion(-) (limited to 'src/tools/irm') diff --git a/src/tools/irm/irm.c b/src/tools/irm/irm.c index a674c7ba..1c75a7a5 100644 --- a/src/tools/irm/irm.c +++ b/src/tools/irm/irm.c @@ -36,6 +36,9 @@ static void usage() static int do_help(int argc, char **argv) { + (void) argc; + (void) argv; + usage(); return 0; } diff --git a/src/tools/irm/irm_bind.c b/src/tools/irm/irm_bind.c index 9b37e800..a12a812b 100644 --- a/src/tools/irm/irm_bind.c +++ b/src/tools/irm/irm_bind.c @@ -36,6 +36,9 @@ static void usage() static int do_help(int argc, char **argv) { + (void) argc; + (void) argv; + usage(); return 0; } diff --git a/src/tools/irm/irm_ipcp.c b/src/tools/irm/irm_ipcp.c index 1b523feb..9d7d9532 100644 --- a/src/tools/irm/irm_ipcp.c +++ b/src/tools/irm/irm_ipcp.c @@ -34,6 +34,9 @@ static void usage() static int do_help(int argc, char **argv) { + (void) argc; + (void) argv; + usage(); return 0; } diff --git a/src/tools/irm/irm_unbind.c b/src/tools/irm/irm_unbind.c index 0290e678..7f2d0d7d 100644 --- a/src/tools/irm/irm_unbind.c +++ b/src/tools/irm/irm_unbind.c @@ -36,6 +36,9 @@ static void usage() static int do_help(int argc, char **argv) { + (void) argc; + (void) argv; + usage(); return 0; } diff --git a/src/tools/irm/irm_utils.c b/src/tools/irm/irm_utils.c index 41a1e811..151d1869 100644 --- a/src/tools/irm/irm_utils.c +++ b/src/tools/irm/irm_utils.c @@ -28,7 +28,7 @@ int matches(const char * cmd, const char * pattern) { - int len = strlen(cmd); + size_t len = strlen(cmd); if (len > strlen(pattern)) return -1; -- cgit v1.2.3