From 2a802888e91a274fa49d341da7744ea9c386b150 Mon Sep 17 00:00:00 2001
From: dimitri staessens <dimitri.staessens@ugent.be>
Date: Thu, 20 Apr 2017 14:24:33 +0200
Subject: lib: Fix bad lock in rib

---
 src/lib/rib.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'src/lib')

diff --git a/src/lib/rib.c b/src/lib/rib.c
index 2645e90b..e59e0d94 100644
--- a/src/lib/rib.c
+++ b/src/lib/rib.c
@@ -1407,16 +1407,17 @@ int rib_unpack(uint8_t * packed,
 
         ret = rnode_unpack(msg, root, flags);
 
-        pthread_rwlock_unlock(&rib.lock);
-
         if (ret == 0 && msg->has_hash) {
                 root = rnode_get_child(root, msg->name);
                 if (memcmp(msg->hash.data, root->sha3, SHA3_256_HASH_LEN)) {
                         ro_msg__free_unpacked(msg, NULL);
+                        pthread_rwlock_unlock(&rib.lock);
                         return -EFAULT;
                 }
         }
 
+        pthread_rwlock_unlock(&rib.lock);
+
         ro_msg__free_unpacked(msg, NULL);
 
         free(packed);
-- 
cgit v1.2.3