From 562548ac5342ee7ce35e41569acf9e67be6f878b Mon Sep 17 00:00:00 2001 From: Dimitri Staessens Date: Sat, 21 Feb 2026 12:17:42 +0100 Subject: lib: Fix ssm pool double free MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove double-free in ssm_pool_destroy — ssm_pool_close already frees the pool. The pool sharding test had a free spbs/ptrs on partial malloc failure. Now initializes children array to -1 to prevent reading uninitialized values. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders --- src/lib/ssm/pool.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/lib/ssm/pool.c') diff --git a/src/lib/ssm/pool.c b/src/lib/ssm/pool.c index 97313e7d..5c98b515 100644 --- a/src/lib/ssm/pool.c +++ b/src/lib/ssm/pool.c @@ -506,14 +506,12 @@ void ssm_pool_destroy(struct ssm_pool * pool) if (getpid() != pool->hdr->pid && kill(pool->hdr->pid, 0) == 0) { ssm_pool_close(pool); - free(pool); return; } fn = pool_filename(pool->uid); if (fn == NULL) { ssm_pool_close(pool); - free(pool); return; } -- cgit v1.2.3