From 4dad657dec442052da2177e713e2008862fa1647 Mon Sep 17 00:00:00 2001 From: Sander Vrijders Date: Fri, 23 Feb 2018 16:17:12 +0100 Subject: irmd: Replace fork and execv with posix_spawn This replaces the fork and execv calls with posix_spawn since it is supported on more platforms, and is more efficient. Also fixes some bad indentation. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens --- src/irmd/main.c | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) (limited to 'src/irmd/main.c') diff --git a/src/irmd/main.c b/src/irmd/main.c index 658811e2..74317610 100644 --- a/src/irmd/main.c +++ b/src/irmd/main.c @@ -59,6 +59,7 @@ #include #include #include +#include #ifdef HAVE_LIBGCRYPT #include @@ -685,7 +686,8 @@ static int bind_program(char * prog, if (argv_dup[i] == NULL) { pthread_rwlock_unlock(&irmd.reg_lock); argvfree(argv_dup); - log_err("Failed to bind program %s to %s.", + log_err("Failed to bind program " + "%s to %s.", prog, name); free(progs); free(progn); @@ -1370,22 +1372,14 @@ static pid_t auto_execute(char ** argv) return -1; } - pid = fork(); - if (pid == -1) { - log_err("Failed to fork"); - return pid; - } - - if (pid != 0) { - log_info("Instantiated %s as process %d.", argv[0], pid); - return pid; + if (posix_spawn(&pid, argv[0], NULL, NULL, argv, NULL)) { + log_err("Failed to spawn new process"); + return -1; } - execv(argv[0], argv); + log_info("Instantiated %s as process %d.", argv[0], pid); - log_err("Failed to execute %s.", argv[0]); - - exit(EXIT_FAILURE); + return pid; } static struct irm_flow * flow_req_arr(pid_t pid, @@ -1776,7 +1770,8 @@ void * irm_sanitize(void * o) if (kill(f->n_pid, 0) < 0) { struct shm_flow_set * set; - log_dbg("Process %d gone, deallocating flow %d.", + log_dbg("Process %d gone, deallocating " + "flow %d.", f->n_pid, f->port_id); set = shm_flow_set_open(f->n_pid); if (set != NULL) -- cgit v1.2.3