From b521232a103bc17d826d35f00f956bbbaa05b11d Mon Sep 17 00:00:00 2001 From: Sander Vrijders Date: Thu, 6 Apr 2017 13:25:17 +0200 Subject: ipcpd: shim-eth-llc: Avoid handling mgmt frame under lock This avoids handling the mgmt frames under lock, since it may deadlock if a new mgmt frame arrives in the meantime. --- src/ipcpd/shim-eth-llc/main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/ipcpd/shim-eth-llc/main.c') diff --git a/src/ipcpd/shim-eth-llc/main.c b/src/ipcpd/shim-eth-llc/main.c index 34a25ee2..1b6e02c2 100644 --- a/src/ipcpd/shim-eth-llc/main.c +++ b/src/ipcpd/shim-eth-llc/main.c @@ -532,12 +532,11 @@ static void * eth_llc_ipcp_mgmt_handler(void * o) continue; } - eth_llc_ipcp_mgmt_frame(frame->buf, frame->len, frame->r_addr); - list_del(&frame->next); - free(frame); - pthread_mutex_unlock(ð_llc_data.mgmt_lock); + + eth_llc_ipcp_mgmt_frame(frame->buf, frame->len, frame->r_addr); + free(frame); } } -- cgit v1.2.3