From 0f041c04ea364326c4206b94724bf2944d3d2129 Mon Sep 17 00:00:00 2001 From: dimitri staessens Date: Wed, 4 Jan 2017 18:20:39 +0100 Subject: ipcpd: Revert normal IPCP state correctly The state of the IPCP should revert to INIT when pthread_create fails in the normal and bootstrapping procedures. --- src/ipcpd/normal/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipcpd/normal/main.c b/src/ipcpd/normal/main.c index 8d319894..8db754aa 100644 --- a/src/ipcpd/normal/main.c +++ b/src/ipcpd/normal/main.c @@ -187,6 +187,7 @@ static int normal_ipcp_enroll(char * dst_name) LOG_WARN("Failed to finalize flow manager."); if (ribmgr_fini()) LOG_WARN("Failed to finalize RIB manager."); + ipcp_set_state(IPCP_INIT); pthread_rwlock_unlock(&ipcpi.state_lock); LOG_ERR("Failed to create acceptor thread."); return -1; @@ -269,6 +270,7 @@ static int normal_ipcp_bootstrap(struct dif_config * conf) LOG_WARN("Failed to finalize flow manager."); if (ribmgr_fini()) LOG_WARN("Failed to finalize RIB manager."); + ipcp_set_state(IPCP_INIT); pthread_rwlock_unlock(&ipcpi.state_lock); LOG_ERR("Failed to create acceptor thread."); return -1; -- cgit v1.2.3 From ce64aa294574cc94355f5d744e8d0342a0f19769 Mon Sep 17 00:00:00 2001 From: dimitri staessens Date: Wed, 4 Jan 2017 18:22:44 +0100 Subject: ipcpd: Fix memleaks in directory --- src/ipcpd/normal/dir.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/ipcpd/normal/dir.c b/src/ipcpd/normal/dir.c index c5bb03dd..d9d15f72 100644 --- a/src/ipcpd/normal/dir.c +++ b/src/ipcpd/normal/dir.c @@ -32,6 +32,7 @@ #include #include +#include char * create_path(char * name) { @@ -94,6 +95,8 @@ int dir_name_reg(char * name) char * path; uint64_t * addr; + assert(name); + ro_attr_init(&attr); attr.enrol_sync = true; attr.recv_set = ALL_MEMBERS; @@ -107,10 +110,12 @@ int dir_name_reg(char * name) pathname_destroy(path); return -ENOMEM; } + *addr = ribmgr_address(); if (ro_create(path, &attr, (uint8_t *) addr, sizeof(*addr))) { pathname_destroy(path); + free(addr); LOG_ERR("Failed to create RIB object."); return -1; } @@ -118,6 +123,8 @@ int dir_name_reg(char * name) LOG_DBG("Registered %s.", name); pathname_destroy(path); + free(name); + return 0; } @@ -125,6 +132,8 @@ int dir_name_unreg(char * name) { char * path; + assert(name); + path = create_path(name); if (path == NULL) return -ENOMEM; -- cgit v1.2.3