ouroboros/src, branch 0.19.0

lib: Fix buffer allocation when retransmitting

2022-03-11T16:51:27+00:00

The timerwheel was retransmitting packets and the error check for negative values of the rbuff allocation was instead checking for non-zero values, causing a buffer allocation to succeed but the program to continue down the unhappy path leaving that packet stuck in the buffer unattended. Also fixes wrongly scheduled retransmissions that cause packet storms. FRCP is much more stable now. Still needs some work for high bandwidth-delay products (fast-retransmit). Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix memcpy with NULL in piggyback API

2022-03-08T16:40:18+00:00

If there is no piggyback data, memcpy was passed a NULL pointer in memcpy(buf, NULL, 0) calls, which is undefined behaviour. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Refactor kad_req_create

2022-03-08T16:40:18+00:00

A small refactor of the kad_req_create function's cleanup code. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipdpd: Pass MPL to application at flow_allocation

2022-03-08T16:40:17+00:00

The maximum packet lifetime (MPL) is a property of the flow that needs to be passed to the reliable transmission protocol (FRCP) for its correct operation. Previously, the value of MPL was set fixed as one of the (fixed) Delta-t parameters. This patch makes the MPL a property of the layer, and it can now be set per layer-type at build time. This is a step towards a proper MPL estimator in the flow allocator. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Pass Delta-t params to frcti_create()

2022-03-08T16:40:17+00:00

The parameters were set directly from the build configs. A first step to making FRCP configurable at runtime, is to pass the parameters to the frcti_create() function. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Fix RTT estimator invocation in FRCT

2022-03-03T11:06:04+00:00

The notorious off-by-one hit again. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Fix underflow in keepalive timer

2022-03-03T11:05:57+00:00

If the keepalive would underflow if set to 1-3 ms. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Flag all flows down as the IRMd exits

2022-03-03T11:05:57+00:00

On exit of the IRMd all flows will now be flagged as down, so external applications will not hang anymore. Note: reads keep work from flows that are down until there are no more remaining packets in the buffer, but no more packets can be written. When the RIB is used, the external application may exit a bit later than the IRMd, so I added a brief sleep before the IRMd tries to remove the fuse main directory. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Fix lock reversal in timerwheel

2022-03-03T11:05:57+00:00

There was a lock reversal in the timerwheel. There still is a thorough revision needed of the locking in dev.c after the FRCP logic is completed and tuned. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd, ipcp: Remove socket option in acceptloop

2022-03-03T11:05:57+00:00

We cancel the thread, so the SO_RCVTIMEO is not needed anymore (it dated from when we checked the state every so often. The address sanitizer is complaining about the the cleanup handlers in the acceptloops after the thread gets cancelled in the read(). I've tried to resolve it, but no avail. Pretty convinced it's a false-positive, so ASan will ignore these functions for now. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders