ouroboros/src/irmd, branch 0.11.6

irmd: Fix use-after-free in mainloop

2018-05-07T15:27:49+00:00

The ret_msg struct was free'd but its result could be accessed after a failed write. Fixed by storing the results of the commands in a temporary variable and accessing this upon write failure. Also simplifies some other code. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Make UNIX socket buffer size configurable

2018-05-03T10:26:48+00:00

This makes the buffer size used by the UNIX sockets configurable. In case of a lot of IPCPs in the system it might become too small with the default value, resulting in irm command failures. The user can now easily configure it with an adequate value. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens

irmd: Shut down IPCPs before IRMd internals

2018-04-26T07:56:06+00:00

This will shut down IPCPs before destroying IRMd internals. This fixes warnings from IPCPs trying to send messages and send packets upon IRM shutdown. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Fix unreachable statement

2018-03-28T13:26:22+00:00

The unreachable statement was missed by some compilers. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Fix memleak when failing to list ipcps

2018-03-22T15:29:06+00:00

The list_ipcps call had a memleak in the failure case. Also fixes a compiler warning for a possible uninitialized variable and renumbers the gpb ipcpd message fields. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Simplify reg/unreg API

2018-03-22T11:36:58+00:00

The reg/unreg API is simplified to registering and unregistering a single name with a single IPCP. The functionality associated with registering names was moved from the IRMd to the irm tool. The function to list IPCPs was simplified to return all IPCPs in the system with their basic properties needed for management. The above changes led to some needed changes in the irm tool and the management functions that were depending on the previous behaviour of list_ipcps. Command line functionality to list IPCPs in the system is also added to the irm tool. Some older code was refactored. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Remove obsolete layer to name mappings

2018-03-21T16:51:38+00:00

The IRMd kept a mapping from layer names to registered names, but this is obsolete since the introduction of the query functionality. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Add IPCP over DIX Ethernet

2018-03-10T12:16:06+00:00

This adds an IPC Process that uses DIX Ethernet with an Ethertype that is configurable at bootstrap. This allows parallel DIX layers over the same Ethernet network with different Ethertypes (and one LLC layer). It allows jumbo frames in the future, and should avoid the problems we have with some routers not handling LLC traffic very well. The destination endpoint ID is sent as a 16 bit integer, so the maximum payload is 1498 bytes in standard Ethernet, and 8998 bytes when Jumbo frames are used. The implementation is very similar to the Ethernet LLC IPCP, so it is implemented using preprocessor macros in the single source instead of duplicating code. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Cleanup flow datastructures on exit

2018-02-24T19:26:48+00:00

The irmd was not cleaning up non-deallocated flows upon exit. This bug was probably introduced with the introduction of the threadpool managers. Also fixes a missing rwlock_destroy(). Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Remove dead variable assignments

2018-02-24T11:02:05+00:00

This removes two useless variable assignments from the IRMd, which were remnants from when the pending flow was being deallocated. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens