ouroboros/src/ipcpd, branch 0.21.2

lib: Rename CACEP to CEP and set conngmr timeout

2024-02-26T08:00:09+00:00

The Common Application Connection Establishment Protocol (CACEP) is a RINA construct associated with the Common Distributed Application Protocol (CDAP). We dropped CDAP as O7s sees connection establishment as common to all applications (though it can be a nop). The wiki already refers to this as (O7s) Connection Establishment Protocol (CEP). The connection manager will now timeout waiting for CEP messages to avoid hanging forever, configurable at build time via CONNMGR_RCV_TIMEOUT. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Mitigate race in wait_req_arr and wait_resp

2024-02-26T07:59:15+00:00

The wait_flow_req_arr and wait_flow_resp functions are there to ensure the responses of the IRMd to flow allocation requests arrive in the correct order. These functions use a mutex: alloc_lock. After these functions return, the IPCP will switch to it's own (usually read-write) lock. In the local IPCP, this leaves room for a race where the state of the flow is accessed in alloc_resp before it is updated in wait_flow_req_arr. This race is only visible in the local IPCP, as the other IPCP have to send information between these calls, but it is theoretically possible when using any IPCP for local IPC. In the ipcpd-local, it happens ~0.01% to ~0.03% of flow allocations. This mitigates the problem in the ipcpd-local by adding a 1ms wait to the flow allocation if this race is detected. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Fix flow deallocation timeout

2024-02-26T07:59:15+00:00

The timeout was set to a value calculated as abstime for a cond_wait instead of a timeout, causing flows to linger in the IPCP. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Add build option to use pid as address

2024-02-23T15:41:38+00:00

This adds a build option IPCP_DEBUG_LOCAL that will use the pid as the DT name (address) in the unicast IPCP, which is handy for integration testing and debugging. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Clean up connection when cancelling connect

2024-02-23T15:41:37+00:00

The connection element was not free'd on shutdown during a connect operation. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Revise app flow allocation

2024-02-23T15:41:37+00:00

This revises the application flow allocator to use the flow_info struct/message between the components. Revises the messaging to move the use protocol buffers to its own source (serdes-irm). Adds a timeout to the IRMd flow allocator to make sure flow allocations don't hang forever (this was previously taken care of by the sanitize thread). Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

build: Fix missing newlines at end of file

2024-02-19T13:09:38+00:00

Some files had a newline at the end, others didn't. Now they all do. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Revise IRMd internals

2024-02-19T10:49:07+00:00

This is a full revision of the IRMd internal implementation. The registry is now a proper subcomponent managing its own internal lock (a single mutex). Some tests are added for the registry and its data structures. Some macros for tests are added in . Flow allocation is now more symmetric between the client side (alloc) and server size (accept). Each will create a flow in pending state (ALLOC_PENDING/ACCEPT_PENDING) that is potentially fulfilled by an IPCP using respond_alloc and respond_accept primitives. Deallocation is split in flow_dealloc (application side) and ipcp_flow_dealloc (IPCP side) to get the flow in DEALLOC_PENDING and DEALLOCATED state. Cleanup of failed flow allocation is now properly handled instead of relying on the sanitizer thread. The new sanitizer only needs to monitor crashed processes. On shutdown, the IRMd will now detect hanging processes and SIGKILL them and clean up their fuse mountpoints if needed. A lot of other things have been cleaned up and shuffled around a bit. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix hash conversion in ipcpd-udp

2024-01-31T09:27:57+00:00

The bootstrap function was not returning the correct hash. Bug introduced in 99545fa2. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix memleak in rib_readdir

2024-01-31T09:27:57+00:00

On fail_dup, the last element (0) was not free'd. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders