ouroboros/src/ipcpd, branch 0.19.0

ipcpd: Fix memcpy with NULL in piggyback API

2022-03-08T16:40:18+00:00

If there is no piggyback data, memcpy was passed a NULL pointer in memcpy(buf, NULL, 0) calls, which is undefined behaviour. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Refactor kad_req_create

2022-03-08T16:40:18+00:00

A small refactor of the kad_req_create function's cleanup code. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipdpd: Pass MPL to application at flow_allocation

2022-03-08T16:40:17+00:00

The maximum packet lifetime (MPL) is a property of the flow that needs to be passed to the reliable transmission protocol (FRCP) for its correct operation. Previously, the value of MPL was set fixed as one of the (fixed) Delta-t parameters. This patch makes the MPL a property of the layer, and it can now be set per layer-type at build time. This is a step towards a proper MPL estimator in the flow allocator. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd, ipcp: Remove socket option in acceptloop

2022-03-03T11:05:57+00:00

We cancel the thread, so the SO_RCVTIMEO is not needed anymore (it dated from when we checked the state every so often. The address sanitizer is complaining about the the cleanup handlers in the acceptloops after the thread gets cancelled in the read(). I've tried to resolve it, but no avail. Pretty convinced it's a false-positive, so ASan will ignore these functions for now. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Make flow liveness timeout configurable

2022-03-03T11:00:54+00:00

The qosspec_t now has a timeout value that sets the timeout value of the flow. Flows with a peer that has timed out will now return -EFLOWPEER on flow_read() or flow_write(). Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix some unchecked return values

2022-03-03T11:00:53+00:00

Fixes some unchecked and wrongly checked return values. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix potential double unlock in eth

2022-02-21T08:05:27+00:00

When handling management frames, there was a cancellation point after the unlock, which would cause the cleanup handler to attempt a double unlock if the thread was cancelled at that point. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Refactor sendingflow allocation response

2022-02-21T08:05:26+00:00

Small refactor taking the wait for the flow allocation to complete out. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Refactor flow allocator message handling

2022-02-21T08:05:26+00:00

This refactors the single long function that handles incoming packets destined for the flow allocator. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix hashing and overlapping memcpy in pff

2022-02-18T07:43:15+00:00

The pft hash function assumed mem_hash allocates memory, but it does not. There was also a memcpy with potentially overlapping memory regions, which is undefined behaviour. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders