ouroboros/src/ipcpd, branch 0.18.2

ipcpd: Fix missing return statement

2021-06-23T06:42:15+00:00

The fa_handle_packet function loop is non-void but didn't have a return statement. Only got picked up if I build from AUR, which is weird. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib, ipcpd, irmd: Wrap pthread unlocks for cleanup

2021-06-23T06:36:48+00:00

This add an ouroboros/pthread.h header that wraps the pthread_..._unlock() functions for cleanup using pthread_cleanup_push() as this casting is not safe (and there were definitely bad casts in the code). The close() function is now also wrapped for cleanup in ouroboros/sockets.h. This allows enabling more compiler checks. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Add missing default for switch in shim-data

2021-06-23T06:36:44+00:00

There was a switch-case without a default, causing some compiler warnings. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Disable core lock by default

2021-06-21T06:45:53+00:00

This was beneficial on dual-XEON CPU systems, but on most hardware, this kills performance when running multiple IPCPs on a single CPU. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix buffer overflow in flow allocator RIB.

2021-06-21T06:45:50+00:00

Max value of UINT64 can be 20 characters when printed, need an extra byte for sprintf trailing '\0'. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix congestion window scaling

2021-06-21T06:45:42+00:00

This fixes scaling of the congestion window, which was a buggy mess. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Move RIB initialization to common ground

2021-06-21T06:45:25+00:00

This moves Resource Information Base (RIB) initialization into the ipcp_init() function, so all IPCPs initialize a RIB. The RIB not shows some common IPCP information, such as the IPCP name, IPCP state and the layer name if the IPCP is part of a layer. The initialization of the hash algorithm and layer name was moved out of the common ipcp source because IPCPs may only know this information after enrollment. Some IPCPs were not even storing this information. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix free of uninitialized variable in graph.c

2021-05-28T06:19:53+00:00

The new GCC 11.1 compiler discovered s_dist would be uninitialized with an unknown policy, so it doesn't need to be free'd. Also removes some unneeded includes in broadcast dt.c that I had pending. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

build: Move connmgr and enrolment to common ground

2021-03-28T10:46:32+00:00

The connection manager and enrolment components of the unicast and broadcast IPCP have a lot in common, as conjectured in the paper. The initial implementation of the broadcast IPCP just duplicated the code. This moves the shared functionality to common ground. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

build: Remove raptor IPCP

2021-03-28T10:46:05+00:00

This removes the raptor IPCP. The code hasn't been updated for a while, and wouldn't compile. Raptor served its purpose as a PoC for Ouroboros-over-Ethernet-Layer-1, but giving the extreme niche hardware needed to run it, it's not worth maintaining this anymore. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders