ouroboros/src/ipcpd/unicast, branch 0.24.0

ipcpd: Remove mutex on DT stats

2026-07-19T09:44:36+00:00

There was a bug where the flow's stat mutex was zero'd while held. Removed the mutex alltogether; use stamp != 0 as the validity guard of the flow stats while reading stats. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Add congestion avoidance unit tests

2026-07-19T09:44:36+00:00

Cover the shared per-aggregate contexts, the mb-ecn policy and the link capacity estimator. The controller tests pin the invariants of the algorithm: the first mark is reported immediately, the receiver's congestion mean is independent of packet rate and its window adapts to hold a fixed sample count, increase and decrease are invariant under control cadence, a starved sender still cuts and later recovers, signals age out on rate-relative horizons, capacity feedback derives the rate floor and recovery slope with clamps and a staleness fallback, and the pacer bounds the burst after idle. The estimator tests drive synthetic arrival traces: the capacity code survives a round trip within its resolution, hops combine by MIN, busy-period drain measures the link rate, windows extend on slow links, sparse idle observations are tolerated where unsaturated windows are rejected, shaped links measure at the shaped rate, stale windows are discarded, and windows bordering an empty queue can only lower the estimate. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Rework congestion avoidance

2026-07-19T09:44:36+00:00

Congestion avoidance is a property of the layer, orthogonal to ARQ and to flow control: FRCP retransmits and lets the peer pace the sender, per flow, end-to-end; the IPCP paces path aggregates. Each signal means one thing: a loss triggers a retransmission, a mark means congestion, the peer window means a slow receiver. Every flow is paced by the same rate law whatever its QoS, so a greedy raw sender shares a bottleneck fairly with a reliable stream. The unit of control is the (destination address, QoS cube) aggregate: all flows toward that destination share one controller and one rate; a start-time fair-queuing pacer divides the rate across them by deadline instead of blocking the send path, and a new flow rides the aggregate's estimates at its current rate, with no probing of its own. Slow start runs once per aggregate. The congestion signal is a multi-bit magnitude: forwarders mark packets with their standing queue depth, MAX-combined across hops, so a packet carries the deepest queue on its path. The receiver feeds back a time-integral mean over a window that adapts to the flow's byte rate, measuring a slow flow with the same fidelity as a fast one. The sender runs AIMD scaled by elapsed wall-clock time, which makes the steady-state allocation RTT-independent. The PCI gains one byte: the path capacity as a quarter-log2 code. Forwarders estimate their egress rate from busy-period drain and MIN-stamp the byte, the receiver returns the window minimum with its feedback, and the sender scales its rate floor and additive slope to the bottleneck (C / 32). A deep cut implies a backlogged bottleneck and a backlogged bottleneck advertises its capacity, so the scaled floor is live exactly when recovery needs it: the probe heals a halving in seconds at any link rate, and the floor bounds the deepest hole to a factor 32 below the bottleneck. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix NULL deref in DHT cleanup

2026-07-19T09:44:34+00:00

The dht_kv_find_node_rsp_msg function steals *contacts and NULLs it on success. When the subsequent msg->val allocation fails in dht_kv_find_value_rsp_msg(), the stolen contacts are freed along with the message, and do_dht_kv_find_value_req() is left with contacts == NULL while n_contacts is still positive: its fail_vals loop then dereferences NULL. Found by clang static analyzer. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix unreachable code in dt_init

2026-07-19T09:44:30+00:00

With IPCP_FLOW_STATS disabled, the bmp_destroy() in the dt_init() failure handling was unreachable. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Store local names before DHT peering

2026-07-08T09:02:25+00:00

A name registered before the DHT had a peer stayed unpublished until it neared its expiry deadline. Make a never-stored local value (t_repl == 0) eligible for replication immediately, and flush replication once when the worker starts so such names are published as soon as the DHT is enrolled. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix DHT bootstrap re-seeding

2026-07-08T09:02:24+00:00

The bootstrap seeder reported success as soon as the query was sent. Only skip seeding once the peer is in a bucket, and return -EAGAIN until it actually appears so the caller keeps retrying rather than assuming bootstrap completed. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Use hash_mix64 for pft keys

2026-06-29T06:32:59+00:00

Drops the per-table hash_key flag and the local MD5 hash() helper. The calc_key function now folds the key with hash_mix64 unconditionally. Simplifies pft_create, which no longer takes a bool. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Add flow-update relay

2026-06-29T06:32:58+00:00

This adds an ipcp_flow_update() call to relay opaque messages between the two IRMds (carried by FLOW_IRM_UPDATE messages), which passes it back up to the peer IRMd via ipcp_flow_update_arr(). The broadcast layer does not implement this. Needed for periodic re-keying of encrypted flows via OAP. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Refactor dt stats

2026-06-03T06:02:34+00:00

Use relaxed atomics in hot path to bump stats via dt_stat_inc/dt_stat_load. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders