ouroboros/src/ipcpd/unicast, branch 0.20.3

ipcpd: Broadcast destruction of DHT requests

2023-09-20T16:53:25+00:00

When a request is cancelled/destroyed, all blocking threads should exit. Noticed some hangs on the DHT, this seems to fix/reduce it. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix dereference of unknown pointer type

2023-09-20T16:51:19+00:00

The event handler was dereferencing the pointer to a connection, but the pointer type is not known yet. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Register event handler after scheduler start

2023-09-20T16:51:19+00:00

The event handler was registered before the scheduler was started. Which could in theory cause addition of fds to an uninitialized scheduler. The event handler is now registered after the scheduler is created as part of dt_start. Likewise it now unregisters as part of dt_stop. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Revise logging

2023-08-30T15:12:41+00:00

This revises the logging in the IPCPs to be a more consistent and reduce duplicate messages in nested functions. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Move protobuf definitions to pb/ directory

2023-08-30T15:11:41+00:00

This moves the protobuf definition in the library to a pb/ directory. Also renames the protobuf files and does a quick review of the #define guards in the include library to specify _LIB_ for internal/non-public library headers. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Move alloc race mitigation to common source

2023-08-30T08:33:20+00:00

All flow allocator code was duplicating the mitigation for a race where the IRMd response for the flow allocation with a new flow fd was arriving before the response to the flow_req_arr. This is now moved to the ipcp common source. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Don't release sdb before writing packet

2023-08-30T08:33:20+00:00

The flow allocator fa_alloc_resp would release the packet buffer (sdb) before writing if the response was a failure. Also sets the IPCP allocation timeout in nanoseconds as per the comment. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Set IPCP states in common sources

2023-08-30T08:33:19+00:00

The state of the IPCP was set and checked in the main files, but it's more convenient to do it in the common source. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Simplify including common enrollment code

2023-08-30T08:02:44+00:00

The common enrollment code between the unicast and broadcast IPCP included the same C source from a source file in the unicast and broadcast directories. Now it's handled by defining COMMON_SOURCES for the unicast and broadcast IPCP. For now, only the enrollment component is common. Two things are needed for the connection manager: * Routing to be fixed to use a supporting broadcast layer. Then management flows can be removed from the unicast IPCP (as they are in fact data transfer flows of the broadcast layer that supports the routing dissemination traffic). * DHT to enroll as part of IPCP enrollment. Now it enrolls when a data transfer flow is established to be more akin to how Kademlia nodes join a Kademlia DHT, but this should be revised to adhere more to O7s enrollment concepts. After that, the connection manager code will also be completely shared between the unicast and broadcast layer and the connmgr will also be common code. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Add IDs to enrollment

2023-08-23T11:09:11+00:00

The enrollment messages now have a 64-bit ID to easier track enrollments in the logs in larger scale tests. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders