ouroboros/src/ipcpd/udp, branch 0.19.1

ipcpd: Fix memcpy with NULL in piggyback API

2022-03-08T16:40:18+00:00

If there is no piggyback data, memcpy was passed a NULL pointer in memcpy(buf, NULL, 0) calls, which is undefined behaviour. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipdpd: Pass MPL to application at flow_allocation

2022-03-08T16:40:17+00:00

The maximum packet lifetime (MPL) is a property of the flow that needs to be passed to the reliable transmission protocol (FRCP) for its correct operation. Previously, the value of MPL was set fixed as one of the (fixed) Delta-t parameters. This patch makes the MPL a property of the layer, and it can now be set per layer-type at build time. This is a step towards a proper MPL estimator in the flow allocator. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Make flow liveness timeout configurable

2022-03-03T11:00:54+00:00

The qosspec_t now has a timeout value that sets the timeout value of the flow. Flows with a peer that has timed out will now return -EFLOWPEER on flow_read() or flow_write(). Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix some unchecked return values

2022-03-03T11:00:53+00:00

Fixes some unchecked and wrongly checked return values. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix potential overflow in DDNS resolver

2022-02-18T07:43:14+00:00

The count value could be IPCP_UDP_BUF_SIZE, overflowing buf. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

build: Fix compilation with fuse (RIB) on FreeBSD

2021-06-28T13:29:16+00:00

Compilation failed on FreeBSD 14 with fuse enabled because of some missing definitions. __XSI_VISIBLE must be set before including for some definitions in . FreeBSD doesn't know the MSG_CONFIRM flag to sendto() or CLOCK_REALTIME_COARSE, which are Linux-specific. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib, ipcpd, irmd: Wrap pthread unlocks for cleanup

2021-06-23T06:36:48+00:00

This add an ouroboros/pthread.h header that wraps the pthread_..._unlock() functions for cleanup using pthread_cleanup_push() as this casting is not safe (and there were definitely bad casts in the code). The close() function is now also wrapped for cleanup in ouroboros/sockets.h. This allows enabling more compiler checks. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Move RIB initialization to common ground

2021-06-21T06:45:25+00:00

This moves Resource Information Base (RIB) initialization into the ipcp_init() function, so all IPCPs initialize a RIB. The RIB not shows some common IPCP information, such as the IPCP name, IPCP state and the layer name if the IPCP is part of a layer. The initialization of the hash algorithm and layer name was moved out of the common ipcp source because IPCPs may only know this information after enrollment. Some IPCPs were not even storing this information. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Single UDP port for the ipcpd-udp

2021-01-03T10:59:59+00:00

The UDP layer will now use a single (configurable) UDP port, default 3435. This makes it easer to allocate flows as a client from behind a NAT firewall without having to configure port forwarding rules. So basically, from now on Ouroboros traffic is transported over a bidirectional : UDP tunnel. The reason for not using/allowing different client/server ports is that it would require reading from different sockets using select() or something similar, but since we need the EID anyway (mgmt packets arrive on the same server UDP port), there's not a lot of benefit in doing it. Now the operation is similar to the ipcpd-eth, with the port somewhat functioning as a "layer name", where in UDP, the Ethertype functions as a "layer name". Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

build: Update email addresses

2021-01-03T10:57:05+00:00

The ugent email addresses are shut down, updated to Ouroboros mail addresses. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders