ouroboros/src/ipcpd/normal/pol, branch 0.11.12

ipcpd: Check if mgmt flow event is FLOW_PKT

2018-07-26T22:22:24+00:00

The management flows were considering every event to be a FLOW_PKT event, when in fact it could also be a flow down or up event, resulting in indefinite reads. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens

ipcpd: Fix sequence number check for link state

2018-07-25T11:29:15+00:00

Commit a3903da659e introduced sequence number for the LSAs to make it more robust, but the check was not done properly, and the seqno was always changed regardless of whether it was an old LSA or not. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens

ipcpd: Only forward new LSAs of the LSDB

2018-07-15T09:25:58+00:00

This will add a sequence number to the Link State Advertisements so that upon receiving a LSA we can check if we need to forward the LSA or not. If we already have the LSA with the received seqno in the LSDB we do not forward it. This allows for setting up a management network that has loops since the spanning tree upon which the LSAs are sent is pruned on every hop. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens

ipcpd: Recalculate PFF only if LSDB changed

2018-06-19T11:57:10+00:00

This will add a flag so the PFF is only recalculated if the LSDB has changed. It also removes the instant recalculation of the LSDB if a new neighbor is added, since this might cause instabilities. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens

ipcpd: Change connection down to flow down

2018-06-19T11:55:45+00:00

The DT component was flagging a connection as down and passing the fd that was down. Of course the other components expect a connection instead of just a fd. Now the connection manager will listen to flow up and down events, and flag the connection up or down if needed. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens

ipcpd: Include string for memset in graph.c

2018-05-29T09:01:38+00:00

The memset function was used without including , which some compilers complain about. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

build: Check for variable length arrays

2018-05-28T10:53:36+00:00

The clang and gcc compilers don't complain about variable length arrays using the -c89 flag unless the flag -Wvla or -Wpedantic is set. This also fixes a memleak and two false positive uninitialized variable warnings reported by the clang static analyzer in graph.c. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix bad memory handling in LFA policy

2018-05-04T10:11:17+00:00

The Loop-Free Alternates policy had bad memory management in two places. In the calculation of the LFAs a table was freed in the first iteration of a loop, whereas it was still needed in the other iterations. It is now freed outside of the loop. In the alternate PFF the address structs were not freed upon shutdown, this has been added as well. It also fixes some bad initialization in the LFA calculation function. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens

ipcpd: Recalculate PFF upon adding new neighbor

2018-05-03T15:53:09+00:00

This recalculates the PFF upon adding a new neighbor, so that the network reconverges faster. It is safe to do so since it is only done by the two IPCPs that established the new flow. The PFF is also recalculated every 4 seconds. Signed-off-by: Sander Vrijders Signed-off-by: Dimitri Staessens

lib: Allow disabling partial read

2018-03-19T09:29:21+00:00

This allows disabling partial reads. It adds a flag FLOWFRNOPART that disables partial reads. Partial read is different from partial delivery (FRCTFPARTIAL), which allows delivery of fragments of an incomplete packet and thus potentially corrupted data. FLOWFRNOPART will never deliver corrupted data (unless FRCTFPARTIAL is also set). If FLOWFRNOPART is set and the buffer provided to flow_read is too small for the SDU, that SDU will be discarded and -EMSGSIZE is returned; Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders