ouroboros, branch 0.21.3

irmd: Fix parsing arguments in configfile

2024-03-01T07:32:16+00:00

The argc counter was improperly reset before building the arguments list. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Rename CACEP to CEP and set conngmr timeout

2024-02-26T08:00:09+00:00

The Common Application Connection Establishment Protocol (CACEP) is a RINA construct associated with the Common Distributed Application Protocol (CDAP). We dropped CDAP as O7s sees connection establishment as common to all applications (though it can be a nop). The wiki already refers to this as (O7s) Connection Establishment Protocol (CEP). The connection manager will now timeout waiting for CEP messages to avoid hanging forever, configurable at build time via CONNMGR_RCV_TIMEOUT. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Fix handling destroy during wait timeouts

2024-02-26T07:59:15+00:00

The object must be refreshed from the list to see if it wasn't yet destroyed if the wait times out. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Fix wrong hash length when getting ipcpd

2024-02-26T07:59:15+00:00

The get_ipcpd_by_dst function was returning the hash length of the last IPCP in the list instead of the length of the actual hash. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Fix memleak on cancel

2024-02-26T07:59:15+00:00

If the mainloop is cancelled during a write, the response buffer leaks. The IRMd now warns about failed writes only when the error is not EPIPE, as EPIPE is expected to happen with timed out requests. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Mitigate race in wait_req_arr and wait_resp

2024-02-26T07:59:15+00:00

The wait_flow_req_arr and wait_flow_resp functions are there to ensure the responses of the IRMd to flow allocation requests arrive in the correct order. These functions use a mutex: alloc_lock. After these functions return, the IPCP will switch to it's own (usually read-write) lock. In the local IPCP, this leaves room for a race where the state of the flow is accessed in alloc_resp before it is updated in wait_flow_req_arr. This race is only visible in the local IPCP, as the other IPCP have to send information between these calls, but it is theoretically possible when using any IPCP for local IPC. In the ipcpd-local, it happens ~0.01% to ~0.03% of flow allocations. This mitigates the problem in the ipcpd-local by adding a 1ms wait to the flow allocation if this race is detected. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Fix flow deallocation timeout

2024-02-26T07:59:15+00:00

The timeout was set to a value calculated as abstime for a cond_wait instead of a timeout, causing flows to linger in the IPCP. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Always use reg_destroy_proc

2024-02-23T15:41:38+00:00

Destroying a process will now always be done with reg_destroy_proc, regardless of whether it was an IPCP or spawned. This makes it easier to keep the registry consistent and avoid races. Also improves some logs and updates some default settings. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Add build option to use pid as address

2024-02-23T15:41:38+00:00

This adds a build option IPCP_DEBUG_LOCAL that will use the pid as the DT name (address) in the unicast IPCP, which is handy for integration testing and debugging. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Clean up connection when cancelling connect

2024-02-23T15:41:37+00:00

The connection element was not free'd on shutdown during a connect operation. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders