ouroboros, branch 0.18.2

ipcpd: Fix missing return statement

2021-06-23T06:42:15+00:00

The fa_handle_packet function loop is non-void but didn't have a return statement. Only got picked up if I build from AUR, which is weird. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib, ipcpd, irmd: Wrap pthread unlocks for cleanup

2021-06-23T06:36:48+00:00

This add an ouroboros/pthread.h header that wraps the pthread_..._unlock() functions for cleanup using pthread_cleanup_push() as this casting is not safe (and there were definitely bad casts in the code). The close() function is now also wrapped for cleanup in ouroboros/sockets.h. This allows enabling more compiler checks. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Add missing default for switch in shim-data

2021-06-23T06:36:44+00:00

There was a switch-case without a default, causing some compiler warnings. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Bypass assertion in shm_rdrbuff

2021-06-21T06:46:47+00:00

This assert() causes ipcpd and subsequent irmd abort() when shutting down debug builds. Should be fixed some day when other components are more robust (frct retransmissions and routing). Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Disable core lock by default

2021-06-21T06:45:53+00:00

This was beneficial on dual-XEON CPU systems, but on most hardware, this kills performance when running multiple IPCPs on a single CPU. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix buffer overflow in flow allocator RIB.

2021-06-21T06:45:50+00:00

Max value of UINT64 can be 20 characters when printed, need an extra byte for sprintf trailing '\0'. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix congestion window scaling

2021-06-21T06:45:42+00:00

This fixes scaling of the congestion window, which was a buggy mess. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Move RIB initialization to common ground

2021-06-21T06:45:25+00:00

This moves Resource Information Base (RIB) initialization into the ipcp_init() function, so all IPCPs initialize a RIB. The RIB not shows some common IPCP information, such as the IPCP name, IPCP state and the layer name if the IPCP is part of a layer. The initialization of the hash algorithm and layer name was moved out of the common ipcp source because IPCPs may only know this information after enrollment. Some IPCPs were not even storing this information. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

tools: Support broadcast IPCP in irm ipcp list

2021-06-18T06:44:26+00:00

The broadcast IPCP was missing in the known types, causing the type to show as UNKNOWN. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

build: Fix version in CMakeLists.txt

2021-06-18T06:44:22+00:00

The tag was set to 0.18, but the version was still at 17.5 in CMake. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders